feat(eslint-plugin): [naming-convention] add support for #private modifier on class members

[hlysine]

PR Checklist

• Addresses an existing open issue: fixes Enhancement: [naming-convention] add support for #private members #6258
• That issue was marked as accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

Currently, a class member with a private identifier (#private) is essentially treated as one with a public modifier. This PR adds the #private modifier option to target this kind of member.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8c95e78. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 47 targets

• Node 18 - nx test eslint-plugin
• Node 14 - nx test eslint-plugin --coverage=false
• nx run-many --target=lint --all --parallel
• nx run-many --target=typecheck --all --parallel
• Node 18 - nx test type-utils
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test eslint-plugin-internal
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test visitor-keys
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test scope-manager
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test typescript-estree
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test utils
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test parser
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test eslint-plugin-tslint
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test type-utils --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test typescript-estree --coverage=false
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test parser --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test visitor-keys --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test eslint-plugin-tslint --coverage=false
• Node 14 - nx test scope-manager --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test eslint-plugin-internal --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test ast-spec
• Node 14 - nx test utils --coverage=false
• Node 14 - nx test ast-spec --coverage=false
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website

---

Sent with 💌 from NxCloud.

[typescript-eslint]

Thanks for the PR, @hlysine!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	8c95e78
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/63ccd0a4a281530008d6516b
😎 Deploy Preview	https://deploy-preview-6259--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[codecov]

Codecov Report

Merging #6259 (8c95e78) into main (503bfde) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6259   +/-   ##
=======================================
  Coverage   91.27%   91.27%           
=======================================
  Files         366      366           
  Lines       12445    12447    +2     
  Branches     3645     3646    +1     
=======================================
+ Hits        11359    11361    +2     
  Misses        772      772           
  Partials      314      314           

Flag	Coverage Δ
unittest	91.27% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...-plugin/src/rules/naming-convention-utils/enums.ts	100.00% <ø> (ø)
...plugin/src/rules/naming-convention-utils/schema.ts	100.00% <ø> (ø)
...kages/eslint-plugin/src/rules/naming-convention.ts	82.02% <100.00%> (+0.16%)	⬆️

[JoshuaKGoldberg]

LGTM, thanks! 🚀

This rule & its tests don't quite adhere to the same standards the rest of the codebase does, such as having one behavior under test per test case... eventually I'll have the energy to file an issue about cleaning it up. Eventually. 🫠