fix(eslint-plugin): [no-shadow] add call and method signatures to ignoreFunctionTypeParameterNameValueShadow

[JoshuaKGoldberg]

PR Checklist

• Addresses an existing open issue: fixes Bug: [no-shadow] ignoreFunctionTypeParameterNameValueShadow = true false positive on function interface dec #6098
• That issue was marked as accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

Adds call signatures and method signatures to the node types that no-shadow will ignore when ignoreFunctionTypeParameterNameValueShadow is true.

I embarrassingly got this rule's logic wrong the first time I tried triaging the issues, so asking for more oversight here. 🥲

[typescript-eslint]

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4dba7d7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 47 targets

• Node 18 - nx test @typescript-eslint/eslint-plugin
• Node 14 - nx test @typescript-eslint/eslint-plugin --coverage=false
• nx run-many --target=lint --all --parallel
• Node 18 - nx test @typescript-eslint/visitor-keys
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/type-utils
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/utils
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=typecheck --all --parallel
• Node 14 - nx test @typescript-eslint/utils --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/typescript-estree
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/eslint-plugin-internal
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/visitor-keys --coverage=false
• Node 18 - nx test @typescript-eslint/eslint-plugin-tslint
• Node 18 - nx test @typescript-eslint/ast-spec
• Node 18 - nx test @typescript-eslint/parser
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/parser --coverage=false
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/ast-spec --coverage=false
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/typescript-estree --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/scope-manager
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/eslint-plugin-tslint --coverage=false
• Node 14 - nx test @typescript-eslint/scope-manager --coverage=false
• Node 14 - nx test @typescript-eslint/type-utils --coverage=false
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/eslint-plugin-internal --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website

---

Sent with 💌 from NxCloud.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	4dba7d7
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/638661fae26f2f000835a43e
😎 Deploy Preview	https://deploy-preview-6129--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[codecov]

Codecov Report

Merging #6129 (4dba7d7) into main (2abadc6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6129   +/-   ##
=======================================
  Coverage   91.27%   91.27%           
=======================================
  Files         366      366           
  Lines       12417    12420    +3     
  Branches     3631     3632    +1     
=======================================
+ Hits        11333    11336    +3     
  Misses        774      774           
  Partials      310      310           

Flag	Coverage Δ
unittest	91.27% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/eslint-plugin/src/rules/no-shadow.ts	77.65% <100.00%> (+0.12%)	⬆️
...s/eslint-plugin/src/rules/prefer-optional-chain.ts	98.63% <0.00%> (+0.01%)	⬆️

[bradzacher]