fix(eslint-plugin): [sort-type-constituents, sort-type-union-intersection-members] handle some required parentheses cases in the fixer

[cherryblossom000]

PR Checklist

• Addresses an existing open issue: fixes Bug: [sort-type-union-intersection-members] Fix for constituents with leading pipes or ampersands produces invalid output #6117
• That issue was marked as accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

requiresParentheses now returns true for union types starting with | and intersection types starting with &.

[typescript-eslint]

Thanks for the PR, @cherryblossom000!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2cf2ca9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 47 targets

• Node 18 - nx test @typescript-eslint/eslint-plugin
• Node 14 - nx test @typescript-eslint/eslint-plugin --coverage=false
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/type-utils
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/utils
• Node 18 - nx test @typescript-eslint/visitor-keys
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=lint --all --parallel
• nx run-many --target=typecheck --all --parallel
• Node 14 - nx test @typescript-eslint/typescript-estree --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/parser
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/visitor-keys --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/type-utils --coverage=false
• Node 18 - nx test @typescript-eslint/scope-manager
• Node 14 - nx test @typescript-eslint/utils --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/eslint-plugin-tslint
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/ast-spec
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/ast-spec --coverage=false
• Node 18 - nx test @typescript-eslint/typescript-estree
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/eslint-plugin-internal
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/scope-manager --coverage=false
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/eslint-plugin-tslint --coverage=false
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/eslint-plugin-internal --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/parser --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website

---

Sent with 💌 from NxCloud.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	2cf2ca9
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/638541d3e7f6e00008238f48
😎 Deploy Preview	https://deploy-preview-6118--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[codecov]

Codecov Report

Merging #6118 (d7f2588) into main (267da4e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head d7f2588 differs from pull request most recent head 2cf2ca9. Consider uploading reports for the commit 2cf2ca9 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6118      +/-   ##
==========================================
- Coverage   91.27%   91.26%   -0.01%     
==========================================
  Files         366      366              
  Lines       12417    12416       -1     
  Branches     3631     3632       +1     
==========================================
- Hits        11333    11332       -1     
  Misses        774      774              
  Partials      310      310              

Flag	Coverage Δ
unittest	91.26% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../eslint-plugin/src/rules/sort-type-constituents.ts	90.38% <100.00%> (-0.36%)	⬇️
.../src/rules/sort-type-union-intersection-members.ts	90.38% <100.00%> (-0.36%)	⬇️
packages/eslint-plugin/src/util/misc.ts	97.01% <100.00%> (+0.13%)	⬆️

[JoshuaKGoldberg]

Code looks great, thanks! Just requesting changes on deduplicating it a bit. ✨

[JoshuaKGoldberg]

Nit: any particular reason to add the return type explicitly, here and in the other file?

[cherryblossom000]

I wanted to make it clear what the Constituent was and where it came from. I ended up getting rid of Constituent when I extracted requiresParentheses into a utility function.

[cherryblossom000]

The force push is because I rebased with main due to a merge conflict.

[cherryblossom000]

I also realised there’s another bug with this rule:

type T = (B | C) & A

gets fixed to

type T = C | A & B

This is because (B | C) & A gets incorrectly fixed to A & B | C, which is then fixed to C | A & B.

[bradzacher]

I wonder if we want to leverage TS's utilities here for completeness?
https://github.com/microsoft/TypeScript/blob/1b75edcec60415dfa77be2e04aeafce0efa2222e/src/compiler/factory/parenthesizerRules.ts

We probably can't consume them directly (cos I don't think the util existed in old versions of TS) - but we could probably fork it? Maybe something to do in a separate PR?

[bradzacher]

Thanks for the fix for both rules!

I'm going to land this as is so we can get the fix out ASAP.
If we want to strengthen the logic further we can follow up in a separate PR.