feat(eslint-plugin): [adjacent-overload-signatures] check BlockStatement nodes #5998
Conversation
|
Thanks for the PR, @lsdsjy! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
Nx Cloud ReportCI is running for commit 5b25f2a. 📂 Click to track the progress, see the status, the terminal output, and the build insights. Sent with 💌 from NxCloud. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Thanks for sending this in @lsdsjy! Per our Contributing guide we normally ask that PRs address a previously-opened issue, to help us triage requests & make sure they're valid before sending.
In this case I think it's fine to not because the bug is pretty clear. So just for next time please 😄
Requesting changes on what I mentioned inline.
packages/eslint-plugin/tests/rules/adjacent-overload-signatures.test.ts
Outdated
Show resolved
Hide resolved
JoshuaKGoldberg
added
the
awaiting response
bradzacher
changed the title
PR Checklist
Overview
Overloaded function declarations can also appear in BlockStatements and should be checked.