Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: [prefer-optional-chain] Unexpected member property type: Identifier #5991

Closed
4 tasks done
sviat9440 opened this issue Nov 15, 2022 · 1 comment · Fixed by #5992
Closed
4 tasks done

Bug: [prefer-optional-chain] Unexpected member property type: Identifier #5991

sviat9440 opened this issue Nov 15, 2022 · 1 comment · Fixed by #5992
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@sviat9440
Copy link
Contributor

sviat9440 commented Nov 15, 2022

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Playground Link

https://typescript-eslint.io/play/#ts=4.8.4&sourceType=module&code=CYUwxgNghgTiAEYD2A7AzgF3gSwFzyhQE8BuAWAChRJYFl0tYYoj9DTLKBCJlgbWzwA1PACMAXXgAfKfB4xmRAcPgAmcZSA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6Y6RAM0WloHsalfkwCG8WmQAWo5uii9o-aJHBgAviHVA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3QAacDUjoAHoizJ46IngCGqACL9YmNXl3Cwo9FIC+IM0A

Repro Code

declare const i: any;
declare const array: any;

!array[i + 1] || !array[i + 2]

ESLint Config

module.exports = {
  "rules": {
    "@typescript-eslint/prefer-optional-chain": "error"
  }
}

tsconfig

{
  "compilerOptions": {
    "strictNullChecks": true,
    "experimentalDecorators": true
  }
}

Expected Result

No errors

Actual Result

Unexpected member property type: Identifier

Additional Info

This is a regression of 5.43.0. In version 5.42.1 all works correctly.

Versions

package version
@typescript-eslint/eslint-plugin 5.43.0
@typescript-eslint/parser 5.43.0
TypeScript 4.8.4
ESLint 8.15.0
node web
@sviat9440 sviat9440 added bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for maintainers to take a look labels Nov 15, 2022
@sviat9440
Copy link
Contributor Author

I suppose it was a consequence of these changes: #5594 @omril1

@JoshuaKGoldberg JoshuaKGoldberg added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for maintainers to take a look labels Nov 15, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
2 participants