feat: support Auto Accessor syntax #5926

sosukesuzuki · 2022-11-04T12:47:16Z

PR Checklist

Addresses an existing open issue: partial of TypeScript 4.9 Support #5688
That issue was marked as accepting prs
Steps in CONTRIBUTING.md were taken

Overview

Based on #5716
Supports Auto Accessors.
ref: ESTree definition

nx-cloud · 2022-11-04T12:47:19Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e510ce4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

typescript-eslint · 2022-11-04T12:47:20Z

Thanks for the PR, @sosukesuzuki!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2022-11-04T12:47:23Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`e510ce4`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6384072380ad6700083afd0e
😎 Deploy Preview	https://deploy-preview-5926--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

# Conflicts: # package.json # patches/typescript+4.8.3.patch # patches/typescript+4.9.2-rc.patch # patches/typescript+4.9.3.patch # yarn.lock

bradzacher · 2022-11-18T02:19:53Z

Clarifying ESTree naming consistency before we move forward on this - estree/estree#292

bradzacher · 2022-11-18T02:53:49Z

Looks like babel doesn't support type annotations on auto-accessors: babel/babel#15205

…rt certain cases

bradzacher · 2022-11-18T04:52:33Z

In 3c326c4 I added tooling to the ast-spec fixture tester which allows us to add config for specific fixtures.
This allows us to add a flag to certain fixtures explicitly expecting that babel should error due to it missing support. This lets us assert that some of the fixtures fail due to babel/babel#15205.

For context, changes I have made to this PR:

merged main
add TSAbstractAccessorProperty, which aligns with TSAbstractPropertyDefinition.
add above testing tooling changes
add ast-spec fixture tests for the feature.

This PR is waiting for a decision on naming alignment discussion with ESTree (estree/estree#292) AccessorProperty vs AccessorPropertyDefinition.
This PR is ready to go with the name AccessorProperty though.

codecov · 2022-11-18T05:54:14Z

Codecov Report

Merging #5926 (e510ce4) into main (fe67b1e) will decrease coverage by 0.03%.
The diff coverage is 73.91%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5926      +/-   ##
==========================================
- Coverage   91.28%   91.24%   -0.04%     
==========================================
  Files         366      366              
  Lines       12363    12380      +17     
  Branches     3617     3621       +4     
==========================================
+ Hits        11285    11296      +11     
- Misses        768      774       +6     
  Partials      310      310

Flag	Coverage Δ
unittest	`91.24% <73.91%> (-0.04%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/typescript-estree/src/convert.ts	`97.13% <55.55%> (-0.50%)`	⬇️
...kages/scope-manager/src/referencer/ClassVisitor.ts	`92.74% <75.00%> (-1.43%)`	⬇️
packages/visitor-keys/src/visitor-keys.ts	`100.00% <100.00%> (ø)`

bradzacher · 2022-11-23T20:01:24Z

The AST is staying named as is, so no changes needed there.

Just need to add scope analysis support then this will be good to go.

# Conflicts: # .prettierignore

JoshuaKGoldberg · 2022-11-28T01:18:06Z

packages/ast-spec/typings/global.d.ts

+   * The value should be a description of why there isn't support - for example a github issue URL.
+   */
+  readonly expectBabelToNotSupport?: string;
+}


👍

just noting - this is also ripe for #5932 & #6027

packages/scope-manager/src/referencer/ClassVisitor.ts

packages/typescript-estree/src/convert.ts

JoshuaKGoldberg · 2022-11-28T01:43:59Z

packages/typescript-estree/src/convert.ts

+        const type = (() => {
+          if (isAccessor) {
+            if (isAbstract) {
+              return AST_NODE_TYPES.TSAbstractAccessorProperty;


I'm confused why codecov thinks this isn't covered by tests. I can debug it locally to see the TSAbstractAccessorProperty and AccessorProperty cases being hit. Though, sourcemaps seem to not be working - maybe that's the issue?

it might be because the tests are in ast-spec instead of in here?
maybe we need to adjust how the coverage is collected?

Filed #6116 🤷

bradzacher · 2022-11-28T01:52:38Z

packages/visitor-keys/src/visitor-keys.ts

+  readonly // require keys for all nodes NOT defined in `eslint-visitor-keys`
+  [T in Exclude<
+    AST_NODE_TYPES,
+    KeysDefinedInESLintVisitorKeysCore
+  >]: readonly GetNodeTypeKeys<T>[];
+} & {
+  readonly // optionally allow keys for all nodes defined in `eslint-visitor-keys`
+  [T in KeysDefinedInESLintVisitorKeysCore]?: readonly GetNodeTypeKeys<T>[];


oooooof i didn't see that prettier formatted like this
disgusting.

JoshuaKGoldberg

I played around with this a bunch locally and it works great. Additional 🌟 for the testing infrastructure cleanups. This was also a great excuse for me to get more familiar with #6065 😄

🚢 !

sosukesuzuki · 2022-11-28T07:09:37Z

Thank you!!

StanislavKharchenko · 2022-11-28T12:00:33Z

Hello!
When this feature will be available?

sosukesuzuki added 14 commits November 2, 2022 19:36

feat: update typescript to 4.9.1

be7a623

fix: add patch file for 4.9.1-beta

00882c2

feat(typescript-estree): update version range

692b86c

feat: run generate-lib script

7e68835

chore: update patch for typescript

2b3bbcd

fix: run lint-fix

154f540

feat: update to typescript 4.9.2-rc

d653607

chore: run patch-package

c7cb795

chore: update @types/node

35809e3

feat(ast-spec): add AccessorProperty

3b724d0

chore(ast-spec): use base nodes for PropertyDefinition

6222f3c

feat(typescript-estree): implement convert AccessorProperty

3734248

feat(visitor-keys): add AccessorProperty

7106081

test: add tests for auto accessors

8809d69

sosukesuzuki mentioned this pull request Nov 12, 2022

Inconsistent AST type to ESTree for decorator auto access syntax babel/babel#15188

Open

1 task

bradzacher mentioned this pull request Nov 18, 2022

TypeScript 4.9 Support #5688

Closed

Merge branch 'main' into pr/sosukesuzuki/5926

a64812f

# Conflicts: # package.json # patches/typescript+4.8.3.patch # patches/typescript+4.9.2-rc.patch # patches/typescript+4.9.3.patch # yarn.lock

bradzacher added 2 commits November 18, 2022 13:28

add TSAbstractAccessorProperty and add ast-spec fixture tests

ff3d58c

add ast-spec testing tooling to allow us to expect babel to not suppo…

3c326c4

…rt certain cases

bradzacher added 3 commits November 18, 2022 15:25

explicitly list the non-support reason in the config and snapshot

cff6c30

add missing tsabstractaccessorproperty visitor keys

7201322

remove dead snapshots

acffe0d

JoshuaKGoldberg mentioned this pull request Nov 18, 2022

Docs: Maintenance > Bumping the Babel version #6027

Closed

2 tasks

bradzacher added 2 commits November 28, 2022 10:47

Merge branch 'main' into auto-accesors

31f972c

# Conflicts: # .prettierignore

add scope analysis support

e510ce4

bradzacher marked this pull request as ready for review November 28, 2022 00:56

JoshuaKGoldberg reviewed Nov 28, 2022

View reviewed changes

packages/scope-manager/src/referencer/ClassVisitor.ts Show resolved Hide resolved

JoshuaKGoldberg reviewed Nov 28, 2022

View reviewed changes

packages/typescript-estree/src/convert.ts Show resolved Hide resolved

JoshuaKGoldberg reviewed Nov 28, 2022

View reviewed changes

bradzacher reviewed Nov 28, 2022

View reviewed changes

JoshuaKGoldberg approved these changes Nov 28, 2022

View reviewed changes

bradzacher merged commit becd1f8 into typescript-eslint:main Nov 28, 2022

JoshuaKGoldberg mentioned this pull request Nov 28, 2022

Repo: Source maps don't connect for ast-spec fixtures.test.ts #6116

Open

sosukesuzuki deleted the auto-accesors branch November 28, 2022 07:07

rostislav-simonik mentioned this pull request Dec 1, 2022

@typescript-eslint/eslint-plugin features to consider (rolling issue) mightyiam/eslint-config-love#665

Open

github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support Auto Accessor syntax #5926

feat: support Auto Accessor syntax #5926

sosukesuzuki commented Nov 4, 2022

nx-cloud bot commented Nov 4, 2022 •

edited

typescript-eslint bot commented Nov 4, 2022

netlify bot commented Nov 4, 2022 •

edited

bradzacher commented Nov 18, 2022

bradzacher commented Nov 18, 2022

bradzacher commented Nov 18, 2022

codecov bot commented Nov 18, 2022 •

edited

bradzacher commented Nov 23, 2022

JoshuaKGoldberg Nov 28, 2022 •

edited

JoshuaKGoldberg Nov 28, 2022 •

edited

bradzacher Nov 28, 2022

JoshuaKGoldberg Nov 28, 2022

bradzacher Nov 28, 2022

JoshuaKGoldberg left a comment

sosukesuzuki commented Nov 28, 2022

StanislavKharchenko commented Nov 28, 2022

feat: support Auto Accessor syntax #5926

feat: support Auto Accessor syntax #5926

Conversation

sosukesuzuki commented Nov 4, 2022

PR Checklist

Overview

nx-cloud bot commented Nov 4, 2022 • edited

☁️ Nx Cloud Report

typescript-eslint bot commented Nov 4, 2022

netlify bot commented Nov 4, 2022 • edited

✅ Deploy Preview for typescript-eslint ready!

bradzacher commented Nov 18, 2022

bradzacher commented Nov 18, 2022

bradzacher commented Nov 18, 2022

codecov bot commented Nov 18, 2022 • edited

Codecov Report

bradzacher commented Nov 23, 2022

JoshuaKGoldberg Nov 28, 2022 • edited

Choose a reason for hiding this comment

JoshuaKGoldberg Nov 28, 2022 • edited

Choose a reason for hiding this comment

bradzacher Nov 28, 2022

Choose a reason for hiding this comment

JoshuaKGoldberg Nov 28, 2022

Choose a reason for hiding this comment

bradzacher Nov 28, 2022

Choose a reason for hiding this comment

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

sosukesuzuki commented Nov 28, 2022

StanislavKharchenko commented Nov 28, 2022

nx-cloud bot commented Nov 4, 2022 •

edited

netlify bot commented Nov 4, 2022 •

edited

codecov bot commented Nov 18, 2022 •

edited

JoshuaKGoldberg Nov 28, 2022 •

edited

JoshuaKGoldberg Nov 28, 2022 •

edited