fix(eslint-plugin): [no-shadow] handle false positives on generics and parameters

[yeonjuan]

PR Checklist

• Addresses an existing open issue: fixes Bug: [typescript-eslint/no-shadow] Rest (...args) parameter name in generic declaration shadows actual parameter name #5853
• That issue was marked as accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

[typescript-eslint]

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3652ffc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 46 targets

• Node 18 - nx test @typescript-eslint/eslint-plugin
• Node 14 - nx test @typescript-eslint/eslint-plugin --coverage=false
• Node 18 - nx test @typescript-eslint/visitor-keys
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/type-utils
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/utils
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=typecheck --all --parallel
• Node 18 - nx test @typescript-eslint/typescript-estree
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/scope-manager
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/utils --coverage=false
• Node 14 - nx test @typescript-eslint/scope-manager --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/parser
• Node 18 - nx test @typescript-eslint/eslint-plugin-tslint
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/parser --coverage=false
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/eslint-plugin-internal --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/ast-spec --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/ast-spec
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/eslint-plugin-internal
• Node 14 - nx test @typescript-eslint/typescript-estree --coverage=false
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/eslint-plugin-tslint --coverage=false
• nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/type-utils --coverage=false
• Node 14 - nx test @typescript-eslint/visitor-keys --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website

---

Sent with 💌 from NxCloud.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	3652ffc
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/63717d405ced6000081028c4
😎 Deploy Preview	https://deploy-preview-5902--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[codecov]

Codecov Report

Merging #5902 (e4fa515) into main (91d71bc) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head e4fa515 differs from pull request most recent head 3652ffc. Consider uploading reports for the commit 3652ffc to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5902      +/-   ##
==========================================
- Coverage   91.39%   91.37%   -0.03%     
==========================================
  Files         365      365              
  Lines       12327    12193     -134     
  Branches     3606     3558      -48     
==========================================
- Hits        11266    11141     -125     
+ Misses        755      747       -8     
+ Partials      306      305       -1     

Flag	Coverage Δ
unittest	91.37% <100.00%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/eslint-plugin/src/rules/no-shadow.ts	77.52% <100.00%> (+1.68%)	⬆️
...s/eslint-plugin/src/rules/prefer-optional-chain.ts	93.85% <0.00%> (-4.77%)	⬇️
...gin/src/rules/naming-convention-utils/validator.ts	95.54% <0.00%> (-1.28%)	⬇️
...lugin-internal/src/rules/plugin-test-formatting.ts	79.85% <0.00%> (-1.08%)	⬇️
...kages/eslint-plugin/src/rules/naming-convention.ts	81.09% <0.00%> (-0.77%)	⬇️
...ackages/eslint-plugin/src/rules/no-extra-parens.ts	90.78% <0.00%> (-0.68%)	⬇️
...eslint-plugin/src/rules/consistent-type-imports.ts	94.26% <0.00%> (-0.29%)	⬇️
packages/utils/src/ts-eslint/RuleTester.ts	100.00% <0.00%> (ø)
.../eslint-plugin/src/rules/sort-type-constituents.ts	90.74% <0.00%> (ø)
...-plugin/src/rules/naming-convention-utils/enums.ts	100.00% <0.00%> (ø)
... and 4 more

[JoshuaKGoldberg]

💯, thanks for fixing this @yeonjuan! 🚀

[andsens]

Awesome stuff @yeonjuan! Thank you very much :-)