Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Website: Add a happy message to playground output pane when no errors or AST #5868

Closed
2 tasks done
JoshuaKGoldberg opened this issue Oct 24, 2022 · 2 comments · Fixed by #5873
Closed
2 tasks done

Website: Add a happy message to playground output pane when no errors or AST #5868

JoshuaKGoldberg opened this issue Oct 24, 2022 · 2 comments · Fixed by #5873
Labels
accepting prs Go ahead, send a pull request that resolves this issue good first issue Good for newcomers package: website Issues related to the @typescript-eslint website

Comments

@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Oct 24, 2022 •
edited

Before You File a Documentation Request Please Confirm You Have Done The Following...

Suggested Changes

This is what the playground looks like when there are no code errors and AST Viewer is disabled:

Screenshot of the playground with no code or output

There's nothing to indicate that ESLint & TypeScript ran successfully and produced no complaints. Let's add a default message there when there isn't.

Maybe: No ESLint or TypeScript messages created? Or some more friendly version of that phrase?

Affected URL(s)

https://typescript-eslint.io/play
@JoshuaKGoldberg JoshuaKGoldberg added good first issue Good for newcomers triage Waiting for maintainers to take a look accepting prs Go ahead, send a pull request that resolves this issue package: website Issues related to the @typescript-eslint website and removed triage Waiting for maintainers to take a look labels Oct 24, 2022
sviat9440 added a commit to MillerSvt/typescript-eslint that referenced this issue Oct 24, 2022
@sviat9440
feat(website): Add a happy message to playground output pane when no …
e8e1518 
…errors or AST (typescript-eslint#5868)
@sviat9440 sviat9440 mentioned this issue Oct 24, 2022
Merged
3 tasks
@sviat9440
Copy link
Contributor

image

@sviat9440
Copy link
Contributor

sviat9440 commented Oct 24, 2022 •
edited

Suggested messages:
'All is ok!'
'No errors found'
'There are no errors'

Please vote for the option you like best or add your own. I will update the pull request.

JoshuaKGoldberg added a commit that referenced this issue Oct 25, 2022
@sviat9440 @JoshuaKGoldberg
feat(website): Add a happy message to playground output pane when no …
c4e0d86 
…errors or AST (#5868) (#5873)

* feat(website): Add a happy message to playground output pane when no errors or AST (#5868)

* Apply suggestions from code review

Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue good first issue Good for newcomers package: website Issues related to the @typescript-eslint website
Projects
No open projects
Website Playground
Status: Done
Milestone
No milestone
2 participants
@JoshuaKGoldberg @sviat9440