New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(website): store options TypeScript, Enable jsx and AST Viewer in browser's local storage #5769
Conversation
… browser's local storage
Thanks for the PR, @DKurilo! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic, thanks @DKurilo! This works great, nicely done. 🔥
Just a few little nitpicks from me that I can apply before merging.
@@ -0,0 +1,6 @@ | |||
export function hasOwnProperty<X extends object, Y extends PropertyKey>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lol. What a great example of why TypeScript's in
type narrowing sometimes falls short.
(not requesting changes, just griping about the world we live in)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, as I remember, current TS version can infer type from using in
.
PR Checklist
Overview
Each time when website configuration is changed it updates hash in url. After this PR it will also try to store data in local storage and when web site is opened it will take default parameters, apply parameters from local storage (if they exists) and then apply parameters from hash. This way TypeScript version, showAST, and enable jsx will be stored locally:.