Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): store options TypeScript, Enable jsx and AST Viewer in browser's local storage #5769

Merged
merged 6 commits into from Oct 9, 2022

Conversation

DKurilo
Copy link
Contributor

@DKurilo DKurilo commented Oct 9, 2022

PR Checklist

Overview

Each time when website configuration is changed it updates hash in url. After this PR it will also try to store data in local storage and when web site is opened it will take default parameters, apply parameters from local storage (if they exists) and then apply parameters from hash. This way TypeScript version, showAST, and enable jsx will be stored locally:.

@nx-cloud
Copy link

nx-cloud bot commented Oct 9, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a7455e3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @DKurilo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Oct 9, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit a7455e3
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63431b32ddaa0e0008208321
😎 Deploy Preview https://deploy-preview-5769--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Oct 9, 2022
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks @DKurilo! This works great, nicely done. 🔥

Just a few little nitpicks from me that I can apply before merging.

packages/website/src/components/hooks/useHashState.ts Outdated Show resolved Hide resolved
packages/website/src/components/hooks/useHashState.ts Outdated Show resolved Hide resolved
packages/website/src/components/hooks/useHashState.ts Outdated Show resolved Hide resolved
packages/website/src/components/lib/has-own-property.ts Outdated Show resolved Hide resolved
@@ -0,0 +1,6 @@
export function hasOwnProperty<X extends object, Y extends PropertyKey>(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol. What a great example of why TypeScript's in type narrowing sometimes falls short.

(not requesting changes, just griping about the world we live in)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, as I remember, current TS version can infer type from using in.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Website: Remember AST Viewer selection if URL is wiped
2 participants