Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [member-ordering] add natural sort order #5662

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Sep 15, 2022

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@nx-cloud
Copy link

nx-cloud bot commented Sep 15, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6d54800. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Sep 15, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 6d54800
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6356dc99e7f3bb0008b31acf
😎 Deploy Preview https://deploy-preview-5662--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #5662 (a918d3b) into main (9eea5f4) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head a918d3b differs from pull request most recent head 6d54800. Consider uploading reports for the commit 6d54800 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5662      +/-   ##
==========================================
+ Coverage   91.33%   91.35%   +0.02%     
==========================================
  Files         361      360       -1     
  Lines       12030    12013      -17     
  Branches     3503     3498       -5     
==========================================
- Hits        10987    10974      -13     
+ Misses        747      743       -4     
  Partials      296      296              
Flag Coverage Δ
unittest 91.35% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/eslint-plugin/src/rules/member-ordering.ts 95.71% <100.00%> (+0.09%) ⬆️
packages/type-utils/src/isTypeReadonly.ts 85.71% <0.00%> (-0.29%) ⬇️
...lint-plugin/src/rules/prefer-nullish-coalescing.ts 100.00% <0.00%> (ø)
...-plugin/src/rules/no-unsafe-declaration-merging.ts

@JoshuaKGoldberg JoshuaKGoldberg changed the title [WIP] feat(eslint-plugin): [member-ordering] add natural sort order feat(eslint-plugin): [member-ordering] add natural sort order Sep 19, 2022
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review September 19, 2022 00:02
@JoshuaKGoldberg
Copy link
Member Author

Codecov is annoyingly flaky on this PR. I did the only things I could:

bradzacher
bradzacher previously approved these changes Oct 24, 2022
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
small comments - feel free to merge when you're done!

@bradzacher bradzacher added the 1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready label Oct 24, 2022
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@JoshuaKGoldberg JoshuaKGoldberg merged commit 1eaae09 into typescript-eslint:main Oct 24, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the member-ordering-natural-order branch October 24, 2022 19:09
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Nov 2, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.41.0` -> `5.42.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.41.0/5.42.0) |
| [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.41.0` -> `5.42.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.41.0/5.42.0) |

---

### Release Notes

<details>
<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>

### [`v5.42.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5420-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5410v5420-2022-10-31)

[Compare Source](typescript-eslint/typescript-eslint@v5.41.0...v5.42.0)

##### Bug Fixes

-   **ast-spec:** add TSQualifiedName to TypeNode union ([#&#8203;5906](typescript-eslint/typescript-eslint#5906)) ([5c316c1](typescript-eslint/typescript-eslint@5c316c1))
-   **eslint-plugin:** \[no-extra-parens] handle type assertion in extends clause ([#&#8203;5901](typescript-eslint/typescript-eslint#5901)) ([8ed7219](typescript-eslint/typescript-eslint@8ed7219))

##### Features

-   **eslint-plugin:** \[member-ordering] add natural sort order ([#&#8203;5662](typescript-eslint/typescript-eslint#5662)) ([1eaae09](typescript-eslint/typescript-eslint@1eaae09))
-   **eslint-plugin:** \[no-invalid-void-type] better report message for void used as a constituent inside a function return type ([#&#8203;5274](typescript-eslint/typescript-eslint#5274)) ([d806bda](typescript-eslint/typescript-eslint@d806bda))

</details>

<details>
<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>

### [`v5.42.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5420-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5410v5420-2022-10-31)

[Compare Source](typescript-eslint/typescript-eslint@v5.41.0...v5.42.0)

##### Features

-   **scope-manager:** ignore ECMA version ([#&#8203;5881](typescript-eslint/typescript-eslint#5881)) ([3b8d449](typescript-eslint/typescript-eslint@3b8d449))

##### Reverts

-   Revert "feat(scope-manager): ignore ECMA version" ([#&#8203;5888](typescript-eslint/typescript-eslint#5888)) ([2ee81df](typescript-eslint/typescript-eslint@2ee81df)), closes [#&#8203;5888](typescript-eslint/typescript-eslint#5888) [#&#8203;5881](typescript-eslint/typescript-eslint#5881)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC45LjEiLCJ1cGRhdGVkSW5WZXIiOiIzNC4xMC4wIn0=-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1619
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: [member-ordering] 'natural' sorting order from from eslint-plugin-typescript-sort-keys
3 participants