feat(eslint-plugin): [naming-convention] add support for "override" and "async" modifiers (#5310) #5610
Conversation
|
Thanks for the PR, @eliasm307! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Note the original issue (that I raised) was just for |
…nd "async" modifiers (typescript-eslint#5310)
eliasm307
force-pushed
the
naming-convention-Add-override-modifier-support
branch
from
7c5f850
to
58dbdaf
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5610 +/- ##
==========================================
- Coverage 91.59% 91.30% -0.30%
==========================================
Files 369 365 -4
Lines 12391 12267 -124
Branches 3613 3585 -28
==========================================
- Hits 11350 11200 -150
- Misses 685 759 +74
+ Partials 356 308 -48
Flags with carried forward coverage won't be shown. Click here to find out more.
|
packages/eslint-plugin/tests/rules/naming-convention/naming-convention.test.ts
Outdated
Show resolved
Hide resolved
packages/eslint-plugin/tests/rules/naming-convention/naming-convention.test.ts
Outdated
Show resolved
Hide resolved
packages/eslint-plugin/tests/rules/naming-convention/naming-convention.test.ts
Show resolved
Hide resolved
JoshuaKGoldberg
added
the
awaiting response
|
Ping @eliasm307 - do you still have time to work on this? No worries if not, just don't want it pending too long. 🙂 |
|
Hi @JoshuaKGoldberg yeah I've been thinking about this recently but I haven't had a moment to apply the feedback. I'm busy this weekend but might have a look next weekend |
…ve abstract getter change, remove override for variable selector in docs
@JoshuaKGoldberg Thanks for the feedback! I've actioned the feedback you gave, waiting to see if the CI checks pass. Otherwise, let me know if there is anything else. |
| | TSESTree.TSAbstractMethodDefinitionNonComputedName, | ||
| ): boolean { | ||
| return Boolean( | ||
| 'value' in propertyOrMemberNode && |
There was a problem hiding this comment.
Looking at this again: we generally try not to use this string in checking pattern, as it's a little imprecise. We normally check for specific types. But I can see why you did it here (much less code!), and there's already an instance of it in the file.
I think it's fine to check in as-is, and we should separately look into making a lint rule internally that flags this kind of check.
I also think I'd meant to post this in the first review but forgot 😄
There was a problem hiding this comment.
as it's a little imprecise
I agree, and its not great for readability also, its not really clear what the intent of the in is, in terms of what node types its trying to check for, but I went with it since it was used everywhere in that file
I can see why you did it here (much less code!)
Yeah I don't do it like this usually, but I was also surprised how short the code gets, but I'm still a fan of the type utils for better communication (but please don't ask me change it now😅)
There was a problem hiding this comment.
Haha don't worry, I won't 😄
There was a problem hiding this comment.
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.42.1` -> `5.43.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.42.1/5.43.0) | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.42.1` -> `5.43.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.42.1/5.43.0) | --- ### Release Notes <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin)</summary> ### [`v5.43.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#​5430-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5421v5430-2022-11-14) [Compare Source](typescript-eslint/typescript-eslint@v5.42.1...v5.43.0) ##### Bug Fixes - **eslint-plugin:** \[no-shadow] handle false positives on generics and parameters ([#​5902](typescript-eslint/typescript-eslint#5902)) ([769e8c8](typescript-eslint/typescript-eslint@769e8c8)) - **eslint-plugin:** \[promise-function-async] handle keyword token ([#​5907](typescript-eslint/typescript-eslint#5907)) ([f25a94f](typescript-eslint/typescript-eslint@f25a94f)) ##### Features - **eslint-plugin:** \[consistent-type-imports] support fixing to inline types ([#​5050](typescript-eslint/typescript-eslint#5050)) ([75dcdf1](typescript-eslint/typescript-eslint@75dcdf1)) - **eslint-plugin:** \[naming-convention] add support for "override" and "async" modifiers ([#​5310](typescript-eslint/typescript-eslint#5310)) ([#​5610](typescript-eslint/typescript-eslint#5610)) ([c759da1](typescript-eslint/typescript-eslint@c759da1)) - **eslint-plugin:** \[prefer-optional-chain] support suggesting `!foo || !foo.bar` as a valid match for the rule ([#​5594](typescript-eslint/typescript-eslint#5594)) ([923d486](typescript-eslint/typescript-eslint@923d486)) #### [5.42.1](typescript-eslint/typescript-eslint@v5.42.0...v5.42.1) (2022-11-07) ##### Bug Fixes - **eslint-plugin:** isTypeReadonly stack overflow ([#​5875](typescript-eslint/typescript-eslint#5875)) ([#​5876](typescript-eslint/typescript-eslint#5876)) ([2d9a33c](typescript-eslint/typescript-eslint@2d9a33c)) </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/parser)</summary> ### [`v5.43.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#​5430-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5421v5430-2022-11-14) [Compare Source](typescript-eslint/typescript-eslint@v5.42.1...v5.43.0) **Note:** Version bump only for package [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser) #### [5.42.1](typescript-eslint/typescript-eslint@v5.42.0...v5.42.1) (2022-11-07) **Note:** Version bump only for package [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yNC4wIiwidXBkYXRlZEluVmVyIjoiMzQuMjQuMSJ9--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1639 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
PR Checklist
Overview
Added support for "override" and "async" modifiers using existing processes