Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): always expanding collapsible sidebar menus under docs #5608

Conversation

santoshyadavdev
Copy link
Contributor

@santoshyadavdev santoshyadavdev commented Sep 5, 2022

PR Checklist

Overview

@nx-cloud
Copy link

nx-cloud bot commented Sep 5, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fb0e962. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @santoshyadavdev!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Sep 5, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit fb0e962
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/631806010f43940008394749
😎 Deploy Preview https://deploy-preview-5608--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far! Just throwing an idea around ✨

@@ -41,6 +43,7 @@ module.exports = {
{
label: 'Architecture',
type: 'category',
collapsed: false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about switching these to:

Suggested change
collapsed: false,
collapsible: false,

Reasoning: since there are so few menu options, I can't think of any reason why someone would want to collapse them. So the buttons to toggle collapse them are unnecessary UI.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah makes sense, so no collapsible pane at all.

Let me try it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
this is how it looks after this

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Sep 5, 2022
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 thanks @santoshyadavdev!

@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) September 7, 2022 02:46
@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #5608 (4d00dee) into main (45e2912) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 4d00dee differs from pull request most recent head fb0e962. Consider uploading reports for the commit fb0e962 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5608      +/-   ##
==========================================
+ Coverage   91.59%   91.63%   +0.03%     
==========================================
  Files         369      134     -235     
  Lines       12391     1506   -10885     
  Branches     3613      226    -3387     
==========================================
- Hits        11350     1380    -9970     
+ Misses        685       62     -623     
+ Partials      356       64     -292     
Flag Coverage Δ
unittest 91.63% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/src/rules/no-non-null-asserted-optional-chain.ts
...ackages/eslint-plugin/src/rules/no-explicit-any.ts
...-plugin/src/rules/no-unnecessary-type-arguments.ts
...ges/eslint-plugin/src/rules/no-extraneous-class.ts
packages/eslint-plugin/src/rules/await-thenable.ts
packages/eslint-plugin/src/util/objectIterators.ts
...-plugin/src/rules/explicit-function-return-type.ts
...gin/src/rules/non-nullable-type-assertion-style.ts
...ges/eslint-plugin/src/rules/no-inferrable-types.ts
packages/type-utils/src/getTypeName.ts
... and 225 more

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
awaiting response Issues waiting for a reply from the OP or another party
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Website: Consider always expanding collapsible sidebar menus under docs/
2 participants