Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): add warning on top of formatting rule docs pages #5598

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Screenshot of the formatting danger notice on the brace-style page

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@nx-cloud
Copy link

nx-cloud bot commented Sep 4, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8b19ba0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Sep 4, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 8b19ba0
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6327bc58e4125e000875b482
😎 Deploy Preview https://deploy-preview-5598--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review September 4, 2022 23:47
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) September 19, 2022 00:41
@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #5598 (5bb0a56) into main (75d78a4) will increase coverage by 0.62%.
The diff coverage is n/a.

❗ Current head 5bb0a56 differs from pull request most recent head 8b19ba0. Consider uploading reports for the commit 8b19ba0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5598      +/-   ##
==========================================
+ Coverage   91.01%   91.63%   +0.62%     
==========================================
  Files         365      134     -231     
  Lines       11962     1506   -10456     
  Branches     3483      226    -3257     
==========================================
- Hits        10887     1380    -9507     
+ Misses        781       62     -719     
+ Partials      294       64     -230     
Flag Coverage Δ
unittest 91.63% <ø> (+0.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/scope-manager/src/scope/index.ts 5.26% <0.00%> (-94.74%) ⬇️
packages/scope-manager/src/definition/index.ts 7.69% <0.00%> (-92.31%) ⬇️
packages/scope-manager/src/index.ts 45.45% <0.00%> (-27.28%) ⬇️
packages/scope-manager/src/analyze.ts 65.38% <0.00%> (ø)
packages/scope-manager/src/ScopeManager.ts 79.74% <0.00%> (ø)
packages/scope-manager/src/scope/ForScope.ts 100.00% <0.00%> (ø)
packages/scope-manager/src/scope/ScopeBase.ts 91.46% <0.00%> (ø)
packages/scope-manager/src/scope/TypeScope.ts 100.00% <0.00%> (ø)
packages/scope-manager/src/scope/WithScope.ts 81.81% <0.00%> (ø)
packages/scope-manager/src/scope/BlockScope.ts 100.00% <0.00%> (ø)
... and 268 more

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Add an notice to formatting rules docs pages
2 participants