fix(typescript-estree): don't double add decorators to a parameter property's parameter

[bradzacher]

PR Checklist

• Addresses an existing open issue: fixes Bug: decorators get duplicated in AST for parameter properties #5581
• That issue was marked as accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

Removes the unnecessary block that was added with the 4.8 support and adds a fixture for it

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 716b1ba. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 47 targets

• Node 14 - nx test @typescript-eslint/eslint-plugin --coverage=false
• Node 18 - nx test @typescript-eslint/eslint-plugin
• Node 18 - nx test @typescript-eslint/typescript-estree
• nx run-many --target=build --all --parallel --exclude website
• Node 18 - nx test @typescript-eslint/visitor-keys
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/typescript-estree --coverage=false
• Node 18 - nx test @typescript-eslint/utils
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/type-utils
• Node 18 - nx test @typescript-eslint/scope-manager
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/scope-manager --coverage=false
• Node 14 - nx test @typescript-eslint/parser --coverage=false
• nx run-many --target=typecheck --all --parallel
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/eslint-plugin-internal --coverage=false
• Node 18 - nx test @typescript-eslint/eslint-plugin-internal
• Node 14 - nx test @typescript-eslint/utils --coverage=false
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/ast-spec
• Node 14 - nx test @typescript-eslint/visitor-keys --coverage=false
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/parser
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/type-utils --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/eslint-plugin-tslint
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/eslint-plugin-tslint --coverage=false
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/ast-spec --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website

---

Sent with 💌 from NxCloud.

[typescript-eslint]

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	716b1ba
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/63104103fe54bc00083ae49c
😎 Deploy Preview	https://deploy-preview-5582--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[codecov]

Codecov Report

Merging #5582 (716b1ba) into main (f7c5deb) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5582      +/-   ##
==========================================
- Coverage   91.62%   91.59%   -0.04%     
==========================================
  Files         134      367     +233     
  Lines        1505    12383   +10878     
  Branches      226     3612    +3386     
==========================================
+ Hits         1379    11342    +9963     
- Misses         62      685     +623     
- Partials       64      356     +292     

Flag	Coverage Δ
unittest	91.59% <ø> (-0.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/typescript-estree/src/convert.ts	97.89% <ø> (ø)
...-estree/src/create-program/createDefaultProgram.ts	77.27% <0.00%> (ø)
packages/type-utils/src/propertyTypes.ts	90.90% <0.00%> (ø)
.../eslint-plugin/src/rules/restrict-plus-operands.ts	88.67% <0.00%> (ø)
...ages/eslint-plugin/src/rules/ban-tslint-comment.ts	100.00% <0.00%> (ø)
...-internal/src/rules/no-typescript-estree-import.ts	87.50% <0.00%> (ø)
.../eslint-plugin/src/rules/method-signature-style.ts	89.15% <0.00%> (ø)
...ages/eslint-plugin/src/rules/no-empty-interface.ts	100.00% <0.00%> (ø)
...plugin/src/rules/no-redundant-type-constituents.ts	93.89% <0.00%> (ø)
packages/eslint-plugin-tslint/src/rules/config.ts	97.29% <0.00%> (ø)
... and 224 more