Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): fix decorator regression for pre TS4.8 #5574

Merged
merged 3 commits into from Aug 30, 2022

Conversation

bradzacher
Copy link
Member

PR Checklist

Overview

#5573 will add CI tests for this, so for now you'll have to trust me that this fixes things

@bradzacher bradzacher added the bug Something isn't working label Aug 30, 2022
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@nx-cloud
Copy link

nx-cloud bot commented Aug 30, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3e43f2e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Aug 30, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 3e43f2e
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/630de26fb8b87b00090b9764
😎 Deploy Preview https://deploy-preview-5574--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bradzacher bradzacher marked this pull request as ready for review August 30, 2022 10:51
@bradzacher bradzacher merged commit a603015 into main Aug 30, 2022
@bradzacher bradzacher deleted the 5571-decorator-regression branch August 30, 2022 14:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: [no-unused-vars] 'Component' is defined but never used
2 participants