New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(scope-manager): visit static blocks #5489
fix(scope-manager): visit static blocks #5489
Conversation
Thanks for the PR, @DMartens! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## main #5489 +/- ##
==========================================
- Coverage 91.74% 91.61% -0.13%
==========================================
Files 366 347 -19
Lines 12344 10929 -1415
Branches 3601 3220 -381
==========================================
- Hits 11325 10013 -1312
+ Misses 668 592 -76
+ Partials 351 324 -27
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I'm still pretty new to this area so we should let another maintainer approve. But this seems pretty straightforward 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops - looks like this was supposed to be actioned in #4211 but the visitor wasn't added.
thanks for thsi!
PR Checklist
Overview
Only added the visitor for static blocks for classes as the scope was already present.