Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-useless-constructor] handle parameter decorator #5450

Merged
merged 4 commits into from Aug 16, 2022

Conversation

yeonjuan
Copy link
Contributor

@yeonjuan yeonjuan commented Aug 9, 2022

PR Checklist

Overview

@nx-cloud
Copy link

nx-cloud bot commented Aug 9, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2e7813f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Aug 9, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 2e7813f
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/62fbebc7e26b3f000981eb55
😎 Deploy Preview https://deploy-preview-5450--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #5450 (b012da0) into main (f92e66a) will increase coverage by 2.46%.
The diff coverage is 100.00%.

❗ Current head b012da0 differs from pull request most recent head 2e7813f. Consider uploading reports for the commit 2e7813f to get more accurate results

@@            Coverage Diff             @@
##             main    #5450      +/-   ##
==========================================
+ Coverage   91.36%   93.83%   +2.46%     
==========================================
  Files         132      290     +158     
  Lines        1494     9989    +8495     
  Branches      226     3008    +2782     
==========================================
+ Hits         1365     9373    +8008     
- Misses         65      335     +270     
- Partials       64      281     +217     
Flag Coverage Δ
unittest 93.83% <100.00%> (+2.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../eslint-plugin/src/rules/no-useless-constructor.ts 95.45% <100.00%> (ø)
packages/eslint-plugin/src/rules/await-thenable.ts 100.00% <0.00%> (ø)
...int-plugin/src/rules/strict-boolean-expressions.ts 98.81% <0.00%> (ø)
...s/eslint-plugin/src/rules/no-non-null-assertion.ts 87.09% <0.00%> (ø)
packages/eslint-plugin/src/rules/indent.ts 92.85% <0.00%> (ø)
...es/eslint-plugin/src/rules/no-invalid-void-type.ts 95.12% <0.00%> (ø)
...-plugin/src/rules/explicit-function-return-type.ts 100.00% <0.00%> (ø)
...ackages/eslint-plugin/src/rules/space-infix-ops.ts 100.00% <0.00%> (ø)
...ges/eslint-plugin/src/rules/no-inferrable-types.ts 95.00% <0.00%> (ø)
... and 149 more

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Aug 9, 2022
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks! 🔥

packages/eslint-plugin/src/rules/no-useless-constructor.ts Outdated Show resolved Hide resolved
param => param.type === AST_NODE_TYPES.TSParameterProperty,
param =>
param.type === AST_NODE_TYPES.TSParameterProperty ||
param.decorators?.length,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside: it might be the case that param.decorators would make sense as a check, as it might be that the parser doesn't create param.decorators if it would have length 0. But that's a nuance not yet strongly defined in AST parsing. #5020

@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) August 9, 2022 17:09
@JoshuaKGoldberg JoshuaKGoldberg merged commit 864dbcf into typescript-eslint:main Aug 16, 2022
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Sep 1, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.33.1` -> `5.35.1`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.33.1/5.35.1) |
| [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.33.1` -> `5.35.1`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.33.1/5.35.1) |

---

### Release Notes

<details>
<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>

### [`v5.35.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5351-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5350v5351-2022-08-24)

[Compare Source](typescript-eslint/typescript-eslint@v5.35.0...v5.35.1)

##### Bug Fixes

-   **eslint-plugin:** correct rule schemas to pass ajv validation ([#&#8203;5531](typescript-eslint/typescript-eslint#5531)) ([dbf8b56](typescript-eslint/typescript-eslint@dbf8b56))

### [`v5.35.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5350-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5340v5350-2022-08-24)

[Compare Source](typescript-eslint/typescript-eslint@v5.34.0...v5.35.0)

##### Features

-   **eslint-plugin:** \[explicit-member-accessibility] suggest adding explicit accessibility specifiers ([#&#8203;5492](typescript-eslint/typescript-eslint#5492)) ([0edb94a](typescript-eslint/typescript-eslint@0edb94a))

### [`v5.34.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5340-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5331v5340-2022-08-22)

[Compare Source](typescript-eslint/typescript-eslint@v5.33.1...v5.34.0)

##### Bug Fixes

-   **eslint-plugin:** \[no-useless-constructor] handle parameter decorator ([#&#8203;5450](typescript-eslint/typescript-eslint#5450)) ([864dbcf](typescript-eslint/typescript-eslint@864dbcf))

##### Features

-   **eslint-plugin:** \[prefer-optional-chain] support suggesting `!foo || !foo.bar` as a valid match for the rule ([#&#8203;5266](typescript-eslint/typescript-eslint#5266)) ([aca935c](typescript-eslint/typescript-eslint@aca935c))

#### [5.33.1](typescript-eslint/typescript-eslint@v5.33.0...v5.33.1) (2022-08-15)

##### Bug Fixes

-   missing placeholders in violation messages for `no-unnecessary-type-constraint` and `no-unsafe-argument` (and enable `eslint-plugin/recommended` rules internally) ([#&#8203;5453](typescript-eslint/typescript-eslint#5453)) ([d023910](typescript-eslint/typescript-eslint@d023910))

</details>

<details>
<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>

### [`v5.35.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5351-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5350v5351-2022-08-24)

[Compare Source](typescript-eslint/typescript-eslint@v5.35.0...v5.35.1)

**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)

### [`v5.35.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5350-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5340v5350-2022-08-24)

[Compare Source](typescript-eslint/typescript-eslint@v5.34.0...v5.35.0)

**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)

### [`v5.34.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5340-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5331v5340-2022-08-22)

[Compare Source](typescript-eslint/typescript-eslint@v5.33.1...v5.34.0)

**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)

#### [5.33.1](typescript-eslint/typescript-eslint@v5.33.0...v5.33.1) (2022-08-15)

**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [x] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNjkuMSIsInVwZGF0ZWRJblZlciI6IjMyLjE3My4wIn0=-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Co-authored-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1519
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: no-useless-constructor rule doesn't work properly with NestJS DI
2 participants