fix(ast-spec): NewExpression argument can be SpreadElement now

[burtek]

PR Checklist

• Addresses an existing open issue: fixes Bug: NewExpression doesn't allow SpreadElement as argument #5421
• That issue was marked as accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

NewExpression argument can be SpreadElement now. See #5421 for details

[typescript-eslint]

Thanks for the PR, @burtek!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7542e59. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 47 targets

• Node 18 - nx test @typescript-eslint/eslint-plugin
• Node 12 - nx test @typescript-eslint/eslint-plugin --coverage=false
• Node 18 - nx test @typescript-eslint/scope-manager
• nx run-many --target=build --all --parallel --exclude website
• Node 18 - nx test @typescript-eslint/utils
• Node 18 - nx test @typescript-eslint/typescript-estree
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx test @typescript-eslint/typescript-estree --coverage=false
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/visitor-keys
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx test @typescript-eslint/scope-manager --coverage=false
• nx run-many --target=typecheck --all --parallel
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx test @typescript-eslint/eslint-plugin-internal --coverage=false
• Node 18 - nx test @typescript-eslint/eslint-plugin-internal
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx test @typescript-eslint/utils --coverage=false
• Node 12 - nx test @typescript-eslint/type-utils --coverage=false
• Node 18 - nx test @typescript-eslint/ast-spec
• Node 18 - nx test @typescript-eslint/parser
• Node 18 - nx test @typescript-eslint/eslint-plugin-tslint
• Node 18 - nx test @typescript-eslint/type-utils
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx test @typescript-eslint/parser --coverage=false
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx test @typescript-eslint/eslint-plugin-tslint --coverage=false
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx test @typescript-eslint/ast-spec --coverage=false
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx test @typescript-eslint/visitor-keys --coverage=false
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website

---

Sent with 💌 from NxCloud.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	7542e59
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/62fa74b147e8880008a729b1
😎 Deploy Preview	https://deploy-preview-5422--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[JoshuaKGoldberg]

LGTM, thanks for the quick fix!

Is this technically a breaking change @bradzacher?

[burtek]

LGTM, thanks for the quick fix!

No problem, was surprised when I found this

Is this technically a breaking change @bradzacher?

If you don't mind, how would this change be a breaking change? I don't see any case how this might break existing code, but obviously I must be missing something?

[bradzacher]

Technically it is breaking because someone could previously have code like

declare function acceptsExpr(node: Expression): void;

declare const newExpr: NewExpression;

acceptsExpr(newExpr);

Which will now have a TS error - thus breaking as the users build could break due to the new version.

Though in general we don't classify this sort of correctness change as breaking because the above code is already broken, and all we've done is expose that broken code to the user.

[burtek]

Right, thanks!

[burtek]

@JoshuaKGoldberg @bradzacher sooo, in terms of merging...? Don't wanna look like I'm making you hurry or something, just making sure you don't forget about this PR after the conversation 😆 as far as I know there is a release each monday?

[JoshuaKGoldberg]

😄 no worries on the ping, you raise a good question! Per Brad's point on this generally only breaking already-broken code I think it's safe to go. But I'll defer to @bradzacher here, as Brad's done much more than me with the AST & managing technical breakage.

[JoshuaKGoldberg]

P.S. @burtek - I appreciate you keeping this branch up-to-date, but you don't have to if you don't want. 😄

[bradzacher]

lgtm - thanks for doing this!

[burtek]

P.S. @burtek - I appreciate you keeping this branch up-to-date, but you don't have to if you don't want. 😄

Good to know :D Github said branch is out of date, I thought it's necessary xD