fix(eslint-plugin): [typedef] Support nested array destructuring with type annotation #5311

amorimr · 2022-07-05T22:38:17Z

PR Checklist

Addresses an existing open issue: fixes Bug: [typedef] false positive with deep array destructuring #5233
That issue was marked as accepting prs
Steps in CONTRIBUTING.md were taken

Overview

Update the typedef rule to take into consideration the type annotation of ancestor nodes when destructuring nested arrays.

nx-cloud · 2022-07-05T22:38:20Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6a2561f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

typescript-eslint · 2022-07-05T22:38:22Z

Thanks for the PR, @amorimr!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

netlify · 2022-07-05T22:38:25Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`6a2561f`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/62dac8948ee1270008b4618d
😎 Deploy Preview	https://deploy-preview-5311--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

codecov · 2022-07-05T22:52:34Z

Codecov Report

Merging #5311 (6a2561f) into main (29b7c02) will increase coverage by 2.42%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5311      +/-   ##
==========================================
+ Coverage   91.35%   93.77%   +2.42%     
==========================================
  Files         132      287     +155     
  Lines        1492     9878    +8386     
  Branches      226     2957    +2731     
==========================================
+ Hits         1363     9263    +7900     
- Misses         65      335     +270     
- Partials       64      280     +216

Flag	Coverage Δ
unittest	`93.77% <100.00%> (+2.42%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/eslint-plugin/src/rules/typedef.ts	`96.00% <100.00%> (ø)`
...gin/src/rules/non-nullable-type-assertion-style.ts	`100.00% <0.00%> (ø)`
...kages/eslint-plugin/src/rules/naming-convention.ts	`81.09% <0.00%> (ø)`
packages/eslint-plugin/src/rules/await-thenable.ts	`100.00% <0.00%> (ø)`
packages/eslint-plugin/src/rules/unbound-method.ts	`92.13% <0.00%> (ø)`
...ckages/eslint-plugin/src/rules/no-unsafe-return.ts	`100.00% <0.00%> (ø)`
...s/eslint-plugin/src/rules/no-unused-expressions.ts	`89.47% <0.00%> (ø)`
...s/eslint-plugin/src/rules/no-restricted-imports.ts	`96.42% <0.00%> (ø)`
...ackages/eslint-plugin/src/rules/no-for-in-array.ts	`100.00% <0.00%> (ø)`
...slint-plugin/src/rules/prefer-namespace-keyword.ts	`100.00% <0.00%> (ø)`
... and 146 more

JoshuaKGoldberg

Yup, looks great - thanks!

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.30.7` -> `5.31.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.30.7/5.31.0) | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.30.7` -> `5.31.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.30.7/5.31.0) | --- ### Release Notes <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/eslint-plugin)</summary> ### [`v5.31.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#5310-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5307v5310-2022-07-25) [Compare Source](typescript-eslint/typescript-eslint@v5.30.7...v5.31.0) ##### Bug Fixes - **eslint-plugin:** \[typedef] Support nested array destructuring with type annotation ([#5311](typescript-eslint/typescript-eslint#5311)) ([6d19efe](typescript-eslint/typescript-eslint@6d19efe)) - **scope-manager:** handle typeParameters of TSInstantiationExpression ([#5355](typescript-eslint/typescript-eslint#5355)) ([2595ccf](typescript-eslint/typescript-eslint@2595ccf)) ##### Features - **eslint-plugin:** \[consistent-generic-ctors] check class field declaration ([#5288](typescript-eslint/typescript-eslint#5288)) ([48f996e](typescript-eslint/typescript-eslint@48f996e)) - **eslint-plugin:** \[prefer-nullish-coalescing] add ignoreTernaryTests option ([#4965](typescript-eslint/typescript-eslint#4965)) ([f82727f](typescript-eslint/typescript-eslint@f82727f)) #### [5.30.7](typescript-eslint/typescript-eslint@v5.30.6...v5.30.7) (2022-07-18) ##### Bug Fixes - **eslint-plugin:** \[no-inferrable] fix optional param to valid code ([#5342](typescript-eslint/typescript-eslint#5342)) ([98f6d5e](typescript-eslint/typescript-eslint@98f6d5e)) - **eslint-plugin:** \[no-unused-vars] highlight last write reference ([#5267](typescript-eslint/typescript-eslint#5267)) ([c3f199a](typescript-eslint/typescript-eslint@c3f199a)) #### [5.30.6](typescript-eslint/typescript-eslint@v5.30.5...v5.30.6) (2022-07-11) **Note:** Version bump only for package [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin) #### [5.30.5](typescript-eslint/typescript-eslint@v5.30.4...v5.30.5) (2022-07-04) ##### Bug Fixes - **eslint-plugin:** \[consistent-indexed-object-style] fix record mode fixer for generics with a default value ([#5280](typescript-eslint/typescript-eslint#5280)) ([57f032c](typescript-eslint/typescript-eslint@57f032c)) #### [5.30.4](typescript-eslint/typescript-eslint@v5.30.3...v5.30.4) (2022-07-03) **Note:** Version bump only for package [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin) #### [5.30.3](typescript-eslint/typescript-eslint@v5.30.2...v5.30.3) (2022-07-01) **Note:** Version bump only for package [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin) #### [5.30.2](typescript-eslint/typescript-eslint@v5.30.1...v5.30.2) (2022-07-01) **Note:** Version bump only for package [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin) #### [5.30.1](typescript-eslint/typescript-eslint@v5.30.0...v5.30.1) (2022-07-01) ##### Bug Fixes - **eslint-plugin:** \[no-base-to-string] add missing apostrophe to message ([#5270](typescript-eslint/typescript-eslint#5270)) ([d320174](typescript-eslint/typescript-eslint@58034e3)) </details> <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/parser)</summary> ### [`v5.31.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#5310-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5307v5310-2022-07-25) [Compare Source](typescript-eslint/typescript-eslint@v5.30.7...v5.31.0) **Note:** Version bump only for package [@typescript-eslint/parser](https://github.com/typescript-eslint/parser) #### [5.30.7](typescript-eslint/typescript-eslint@v5.30.6...v5.30.7) (2022-07-18) ##### Bug Fixes - expose types supporting old versions of typescript ([#5339](typescript-eslint/typescript-eslint#5339)) ([4ba9bdb](typescript-eslint/typescript-eslint@4ba9bdb)) #### [5.30.6](typescript-eslint/typescript-eslint@v5.30.5...v5.30.6) (2022-07-11) **Note:** Version bump only for package [@typescript-eslint/parser](https://github.com/typescript-eslint/parser) #### [5.30.5](typescript-eslint/typescript-eslint@v5.30.4...v5.30.5) (2022-07-04) **Note:** Version bump only for package [@typescript-eslint/parser](https://github.com/typescript-eslint/parser) #### [5.30.4](typescript-eslint/typescript-eslint@v5.30.3...v5.30.4) (2022-07-03) **Note:** Version bump only for package [@typescript-eslint/parser](https://github.com/typescript-eslint/parser) #### [5.30.3](typescript-eslint/typescript-eslint@v5.30.2...v5.30.3) (2022-07-01) **Note:** Version bump only for package [@typescript-eslint/parser](https://github.com/typescript-eslint/parser) #### [5.30.2](typescript-eslint/typescript-eslint@v5.30.1...v5.30.2) (2022-07-01) **Note:** Version bump only for package [@typescript-eslint/parser](https://github.com/typescript-eslint/parser) #### 5.30.1 (2022-07-01) **Note:** Version bump only for package [@typescript-eslint/parser](https://github.com/typescript-eslint/parser) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1480 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

fix typedef rule for deep array destructuring

d68261e

bradzacher added the bug Something isn't working label Jul 18, 2022

JoshuaKGoldberg approved these changes Jul 22, 2022

View reviewed changes

JoshuaKGoldberg enabled auto-merge (squash) July 22, 2022 15:55

Merge branch 'main' into fix-5233

6a2561f

bradzacher disabled auto-merge July 22, 2022 17:28

bradzacher merged commit 6d19efe into typescript-eslint:main Jul 22, 2022

github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(eslint-plugin): [typedef] Support nested array destructuring with type annotation #5311

fix(eslint-plugin): [typedef] Support nested array destructuring with type annotation #5311

amorimr commented Jul 5, 2022

nx-cloud bot commented Jul 5, 2022 •

edited

typescript-eslint bot commented Jul 5, 2022

netlify bot commented Jul 5, 2022 •

edited

codecov bot commented Jul 5, 2022 •

edited

JoshuaKGoldberg left a comment

fix(eslint-plugin): [typedef] Support nested array destructuring with type annotation #5311

fix(eslint-plugin): [typedef] Support nested array destructuring with type annotation #5311

Conversation

amorimr commented Jul 5, 2022

PR Checklist

Overview

nx-cloud bot commented Jul 5, 2022 • edited

☁️ Nx Cloud Report

typescript-eslint bot commented Jul 5, 2022

netlify bot commented Jul 5, 2022 • edited

✅ Deploy Preview for typescript-eslint ready!

codecov bot commented Jul 5, 2022 • edited

Codecov Report

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

nx-cloud bot commented Jul 5, 2022 •

edited

netlify bot commented Jul 5, 2022 •

edited

codecov bot commented Jul 5, 2022 •

edited