feat(eslint-plugin): [no-invalid-void-type] better report message for void used as a constituent inside a function return type #5274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix examples and --Isolatedmodules explain
one is correct, another is incorrect
|
@JoshuaKGoldberg @bradzacher |
bradzacher
removed
the
awaiting response
Nope, PRs generally stay open unless some drastic difference in strategy is decided upon (not likely here) or they aren't updated by the author in months. |
packages/eslint-plugin/tests/rules/no-invalid-void-type.test.ts
Outdated
Show resolved
Hide resolved
JoshuaKGoldberg
previously requested changes
Aug 18, 2022
There was a problem hiding this comment.
Let me know if you need help with any of this 🙁. I get the impression this is a lot of new stuff - feel free to ask questions on anything that doesn't make sense!
https://sourcegraph.com/notebooks/Tm90ZWJvb2s6MTA2OA== has some good docs on how our rules work, if that helps.
bradzacher
added
the
awaiting response
|
Ping @kmin-jeong, do you still have time to work on this? No worries if not, just want to make sure it's not pending too long. 🙂 |
|
@JoshuaKGoldberg I don't have enough time to solve this , so can I hand it over to someone else? |
|
No worries, thanks for getting this started! I'll take it over right now. 😄 |
JoshuaKGoldberg
requested review from
bradzacher and
Josh-Cena
and removed request for
JoshuaKGoldberg
JoshuaKGoldberg
removed
the
awaiting response
bradzacher
approved these changes
Oct 27, 2022
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Nov 2, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.41.0` -> `5.42.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.41.0/5.42.0) | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.41.0` -> `5.42.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.41.0/5.42.0) | --- ### Release Notes <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin)</summary> ### [`v5.42.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#​5420-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5410v5420-2022-10-31) [Compare Source](typescript-eslint/typescript-eslint@v5.41.0...v5.42.0) ##### Bug Fixes - **ast-spec:** add TSQualifiedName to TypeNode union ([#​5906](typescript-eslint/typescript-eslint#5906)) ([5c316c1](typescript-eslint/typescript-eslint@5c316c1)) - **eslint-plugin:** \[no-extra-parens] handle type assertion in extends clause ([#​5901](typescript-eslint/typescript-eslint#5901)) ([8ed7219](typescript-eslint/typescript-eslint@8ed7219)) ##### Features - **eslint-plugin:** \[member-ordering] add natural sort order ([#​5662](typescript-eslint/typescript-eslint#5662)) ([1eaae09](typescript-eslint/typescript-eslint@1eaae09)) - **eslint-plugin:** \[no-invalid-void-type] better report message for void used as a constituent inside a function return type ([#​5274](typescript-eslint/typescript-eslint#5274)) ([d806bda](typescript-eslint/typescript-eslint@d806bda)) </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/parser)</summary> ### [`v5.42.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#​5420-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5410v5420-2022-10-31) [Compare Source](typescript-eslint/typescript-eslint@v5.41.0...v5.42.0) ##### Features - **scope-manager:** ignore ECMA version ([#​5881](typescript-eslint/typescript-eslint#5881)) ([3b8d449](typescript-eslint/typescript-eslint@3b8d449)) ##### Reverts - Revert "feat(scope-manager): ignore ECMA version" ([#​5888](typescript-eslint/typescript-eslint#5888)) ([2ee81df](typescript-eslint/typescript-eslint@2ee81df)), closes [#​5888](typescript-eslint/typescript-eslint#5888) [#​5881](typescript-eslint/typescript-eslint#5881) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC45LjEiLCJ1cGRhdGVkSW5WZXIiOiIzNC4xMC4wIn0=--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1619 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Overview
change and error message in case of union type