Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo: filter private packages from the release log #5218

Open
bradzacher opened this issue Jun 20, 2022 · 1 comment
Open

Repo: filter private packages from the release log #5218

bradzacher opened this issue Jun 20, 2022 · 1 comment
Assignees
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@bradzacher
Copy link
Member

bradzacher commented Jun 20, 2022

Suggestion

This week we didn't merge any publicly-facing PRs. However https://github.com/typescript-eslint/typescript-eslint/releases/tag/v5.29.0 was released as a minor bump instead of a patch bump. This was because #5190 was marked as a feat instead of a chore.

These private packages definitely should not contribute to our weekly release version calculation.

We need to look into if lerna can filter these out automatically so we don't need to be strict about the semantic commit labelling. I've been manually updating PR titles as I saw them - but we really shouldn't be relying on a manual process to ensure our automated process is correct.

@bradzacher bradzacher added repo maintenance things to do with maintenance of the repo, and not with code/docs accepting prs Go ahead, send a pull request that resolves this issue labels Jun 20, 2022
@JamesHenry JamesHenry self-assigned this Apr 17, 2024
@JamesHenry
Copy link
Member

Looking into this via the custom changelog renderer option in nx release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Development

No branches or pull requests

2 participants