fix(eslint-plugin): [space-infix-ops] support for optional property without type #5155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @armano2! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
armano2
commented
Jun 6, 2022
| @@ -69,17 +69,16 @@ export default util.createRule<Options, MessageIds>({ | |||
|
|
|||
| function isSpaceChar(token: TSESTree.Token): boolean { | |||
| return ( | |||
| token.type === AST_TOKEN_TYPES.Punctuator && | |||
| /^[=|?|:]$/.test(token.value) | |||
There was a problem hiding this comment.
this regexp was not correct, it should be, /^[=?:]$/ or /^(=|?|:)$/
There was a problem hiding this comment.
This is a pretty common mistake in regexes!
Probably deserves its own lint rule!
There was a problem hiding this comment.
I recommend this plugin, if you have a lot of non-trivial regexps to lint
armano2
commented
Jun 6, 2022
Comment on lines
127
to
129
| node.optional && !node.typeAnnotation | ||
| ? sourceCode.getTokenAfter(node.key) | ||
| : sourceCode.getLastToken(node.typeAnnotation ?? node.key); |
There was a problem hiding this comment.
isSpaceChar is allowing ? as token, than we have to skip it,
This comment was marked as resolved.
This comment was marked as resolved.
Codecov Report
@@ Coverage Diff @@
## main #5155 +/- ##
==========================================
+ Coverage 91.70% 93.82% +2.11%
==========================================
Files 362 286 -76
Lines 12182 9828 -2354
Branches 3531 2939 -592
==========================================
- Hits 11172 9221 -1951
+ Misses 661 328 -333
+ Partials 349 279 -70
Flags with carried forward coverage won't be shown. Click here to find out more. |
armano2
added
package: eslint-plugin
bradzacher
approved these changes
Jun 8, 2022
| @@ -69,17 +69,16 @@ export default util.createRule<Options, MessageIds>({ | |||
|
|
|||
| function isSpaceChar(token: TSESTree.Token): boolean { | |||
| return ( | |||
| token.type === AST_TOKEN_TYPES.Punctuator && | |||
| /^[=|?|:]$/.test(token.value) | |||
There was a problem hiding this comment.
This is a pretty common mistake in regexes!
Probably deserves its own lint rule!
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Jun 17, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.27.1` -> `5.28.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.27.1/5.28.0) | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.27.1` -> `5.28.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.27.1/5.28.0) | --- ### Release Notes <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin)</summary> ### [`v5.28.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#​5280-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5271v5280-2022-06-13) [Compare Source](typescript-eslint/typescript-eslint@v5.27.1...v5.28.0) ##### Bug Fixes - \[TS4.7] allow visiting of typeParameters in TSTypeQuery ([#​5166](typescript-eslint/typescript-eslint#5166)) ([dc1f930](typescript-eslint/typescript-eslint@dc1f930)) - **eslint-plugin:** \[space-infix-ops] support for optional property without type ([#​5155](typescript-eslint/typescript-eslint#5155)) ([1f25daf](typescript-eslint/typescript-eslint@1f25daf)) ##### Features - **eslint-plugin:** \[consistent-generic-constructors] add rule ([#​4924](typescript-eslint/typescript-eslint#4924)) ([921cdf1](typescript-eslint/typescript-eslint@921cdf1)) #### [5.27.1](typescript-eslint/typescript-eslint@v5.27.0...v5.27.1) (2022-06-06) ##### Bug Fixes - **eslint-plugin:** \[space-infix-ops] correct PropertyDefinition with typeAnnotation ([#​5113](typescript-eslint/typescript-eslint#5113)) ([d320174](typescript-eslint/typescript-eslint@d320174)) - **eslint-plugin:** \[space-infix-ops] regression fix for conditional types ([#​5135](typescript-eslint/typescript-eslint#5135)) ([e5238c8](typescript-eslint/typescript-eslint@e5238c8)) - **eslint-plugin:** \[space-infix-ops] regression fix for type aliases ([#​5138](typescript-eslint/typescript-eslint#5138)) ([4e13deb](typescript-eslint/typescript-eslint@4e13deb)) </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/parser)</summary> ### [`v5.28.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#​5280-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5271v5280-2022-06-13) [Compare Source](typescript-eslint/typescript-eslint@v5.27.1...v5.28.0) **Note:** Version bump only for package [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser) #### [5.27.1](typescript-eslint/typescript-eslint@v5.27.0...v5.27.1) (2022-06-06) **Note:** Version bump only for package [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1409 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Overview
Additional regression fix for #5041
/^[=|?|:]$/.test(token.value)Optimizations: