Bug: [space-infix-ops] false positive since version 5.27.0

[paztis]

Before You File a Bug Report Please Confirm You Have Done The Following...

• I have tried restarting my IDE and the issue persists.
• I have updated to the latest version of the packages.
• I have searched for related issues and found none that matched my issue.
• I have read the FAQ and my problem is not listed.

Playground Link

https://typescript-eslint.io/play/#ts=4.7.2&sourceType=module&code=FAOwhgtgpgzgDmAxlABDANgS2QESgMxQG9gUUoAPOAewCcAXFTEeqW-JVASQGV6xWxFAF9go4ABMoidGFqpE1EDEaJ5AqDyjpp9OgC4UYEAE8A3MGCUaDFFI4BXdKtkwYKLTsR7a7kmQxsTW1dOgAKRAdaeRY+DUNA3AIAOl5+VgBKBKwk-FS4wSIUeXookBRI6KhY9KgzEUsyKH4AcxhPUNpDMJV4tByoPDy0jQyUAF4APhQAJWk6CQAeFVpmFoAaNHpVkBbp8dIyCvVWDu9w+gALTBhkxOCvH02egbGp-qDk5rA2jItRIA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKWQBwEMBjRAWgEsA7AM3IA9SB7PVDSR66yAGnG0gACAFwCeeFEWjk8Q0inhUhAenzEyVWg2aswAbT7YoiaNEbQeB7FkP9FAZgBMACUXow1AvGSJLEAL6WALp8AX5AA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA

Repro Code

namespace sliceDef {
  export interface IState { }
}

declare const createSelector: any;

export default class Selectors {
  sliceSelector(currentState: sliceDef.IState): sliceDef.IState { return currentState; }

  etagsSelector: (state: sliceDef.IState) => Record<string, string> =
    createSelector(this.sliceSelector, (slice) => slice.etags);
}

ESLint Config

{
  "rules": {
    "space-infix-ops": "off",
    "@typescript-eslint/space-infix-ops": [
      "error",
      {
        "int32Hint": false
      }
    ]
  }
}

tsconfig

{
  "compilerOptions": {
    "strictNullChecks": true
  }
}

Expected Result

no error

Actual Result

11:26 error Operator ':' must be spaced @typescript-eslint/space-infix-ops

Additional Info

No response

Versions

package	version
@typescript-eslint/eslint-plugin	5.27.0
@typescript-eslint/parser	5.27.0
TypeScript	4.7.2
ESLint	8.16.0
node	16.5.0

[CyanSalt]

I had the same problem. It looks similar to #5115.

The fix has been merged but the latest tag has not been released yet, so maybe we can use canary tag to solve this problem.

[CyanSalt]

It looks like the latest alpha release now fixes the problem in most cases, but does not include those cases that contain extends, e.g.

type Foo<T> = T extends { bar: string } ? string : number
                             ^

type Foo<T> = T extends (bar: string) => void ? string : number
                            ^

[armano2]

@paztis fixed by #5113, can you check canary 5.27.1-alpha.5

[paztis]

Canary is released on npm ? Le mer. 1 juin 2022, 14:27, Armano ***@***.***> a écrit :

…

@paztis <https://github.com/paztis> fixed by #5113 <#5113>, can you check canary 5.27.1-alpha.5 — Reply to this email directly, view it on GitHub <#5133 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABIKMMNQGRCACLZ2ENKZ7X3VM5JLVANCNFSM5XQIN3ZA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[bradzacher]

As mentioned in our root readme
https://github.com/typescript-eslint/typescript-eslint#versioning

[bradzacher]

Please use the issue search before filing an issue. Closed issues are a must when searching.

[paztis]

Wait. I just discover this defect yesterday and was thinking it was due to this 2 days ago commit.
Don't say I don't search on issues before posting.

Now even if the defect is closed it is still not released... When is it supposed to be released ?

[armano2]

all commits that land on main branch are published to npm as canary/alpha versions, in this case bug for your fix is in 5.27.1-alpha.5 https://www.npmjs.com/package/@typescript-eslint/eslint-plugin?activeTab=versions

as for normal release, we usually have them at beginning of the week (~monday)

[bradzacher]

When is it supposed to be released ?

This is explained in the link.
https://github.com/typescript-eslint/typescript-eslint#versioning

Armano is correct - canary off every commit, stable every monday morning PST.