Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug(website): compiler options are not passed to the lint run #5079

Closed
bradzacher opened this issue May 25, 2022 · 1 comment · Fixed by #5061 or #5080
Closed

Bug(website): compiler options are not passed to the lint run #5079

bradzacher opened this issue May 25, 2022 · 1 comment · Fixed by #5061 or #5080
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working package: website Issues related to the @typescript-eslint website

Comments

@bradzacher
Copy link
Member

Best shown via a video:
https://user-images.githubusercontent.com/7462525/170336044-461ec681-59ec-4bfe-8800-e992bb1a8674.mov

It looks like the compiler options are always the default options we set here:

const compilerOptions: Monaco.languages.typescript.CompilerOptions = {
noResolve: true,
target: main.languages.typescript.ScriptTarget.ESNext,
jsx: props.jsx ? main.languages.typescript.JsxEmit.React : undefined,
lib: ['es2021', 'esnext'],
module: main.languages.typescript.ModuleKind.ESNext,
};

Side note: we should add strict: true to the default because it's the best-practice!

@bradzacher bradzacher added bug Something isn't working accepting prs Go ahead, send a pull request that resolves this issue package: website Issues related to the @typescript-eslint website labels May 25, 2022
@armano2
Copy link
Member

armano2 commented May 25, 2022

fixed as part of #5061 and its regression introduced in #5034, if you want i can extract this fix to separate PR

packages/website/src/components/linter/WebLinter.ts

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working package: website Issues related to the @typescript-eslint website
Projects
None yet
2 participants