Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [TS4.7] support type parameters for typeof #5067

Conversation

sosukesuzuki
Copy link
Contributor

PR Checklist

Overview

let x: typeof y.z<w>;

Babel's implementation babel/babel#14457

@nx-cloud
Copy link

nx-cloud bot commented May 24, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8c90aaa. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented May 24, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 8c90aaa
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/628d27c9c2f1f500081e02b8
😎 Deploy Preview https://deploy-preview-5067--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @sosukesuzuki!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #5067 (8c90aaa) into main (3c0f2e3) will increase coverage by 0.37%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5067      +/-   ##
==========================================
+ Coverage   91.32%   91.69%   +0.37%     
==========================================
  Files         132      361     +229     
  Lines        1487    12139   +10652     
  Branches      224     3525    +3301     
==========================================
+ Hits         1358    11131    +9773     
- Misses         65      658     +593     
- Partials       64      350     +286     
Flag Coverage Δ
unittest 91.69% <100.00%> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/typescript-estree/src/convert.ts 98.00% <100.00%> (ø)
...ckages/eslint-plugin/src/rules/no-unsafe-return.ts 100.00% <0.00%> (ø)
packages/type-utils/src/isTypeReadonly.ts 85.71% <0.00%> (ø)
...ckages/eslint-plugin/src/rules/no-throw-literal.ts 97.67% <0.00%> (ø)
...ages/eslint-plugin/src/rules/no-empty-interface.ts 100.00% <0.00%> (ø)
...es/eslint-plugin/src/rules/no-use-before-define.ts 93.33% <0.00%> (ø)
...slint-plugin/src/rules/no-unnecessary-condition.ts 98.30% <0.00%> (ø)
...kages/eslint-plugin/src/rules/naming-convention.ts 81.09% <0.00%> (ø)
...-estree/src/create-program/createProjectProgram.ts 94.11% <0.00%> (ø)
packages/utils/src/ts-eslint/CLIEngine.ts 66.66% <0.00%> (ø)
... and 220 more

@bradzacher bradzacher added enhancement New feature or request AST PRs and Issues about the AST structure labels May 24, 2022
bradzacher
bradzacher previously approved these changes May 24, 2022
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete that one file and we can merge this!
thanks so much for doing this!

amazing_

packages/types/src/ast-spec.ts Outdated Show resolved Hide resolved
@bradzacher bradzacher merged commit 836de79 into typescript-eslint:main May 24, 2022
@sosukesuzuki sosukesuzuki deleted the support-type-parameters-for-query-type branch May 25, 2022 07:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
AST PRs and Issues about the AST structure enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript 4.7 Support
2 participants