feat(eslint-plugin): [consistent-type-imports] support fixing to inline types

[snewcomer]

PR Checklist

• Addresses an existing open issue: fixes [consistent-type-imports] prefer inline type import syntax #4338
• That issue was marked as accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

This PR adds a configuration option inline-type-imports that users can utilize to inline their type imports.

Previously, as on Typescript 3.8, we had the ability to import type. This import would be elided from the build deterministically.

import A, { CType } from 'foo';
import type { AType } from 'foo';
import { BType } from 'foo';

As of 4.5, we can inline that type, making it easier to manage top level imports.

import A, { type CType } from 'foo';
import type { AType } from 'foo';
import { type BType } from 'foo';

The summation of the discussion and work is as follows.

1. fixes a Type import to Inline Type - [New] consistent-type-specifier-style: add rule import-js/eslint-plugin-import#2473.
2. (this PR) fixes a Value import to Inline Type
3. adds support for resolving duplicate Type imports to Inline Types to existing import source [New] no-duplicates: support inline type import with prefer-inline option import-js/eslint-plugin-import#2475

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f92cefd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 46 targets

• Node 18 - nx test @typescript-eslint/typescript-estree
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/visitor-keys
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=typecheck --all --parallel
• Node 18 - nx test @typescript-eslint/utils
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/typescript-estree --coverage=false
• Node 14 - nx test @typescript-eslint/eslint-plugin-tslint --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/parser --coverage=false
• Node 14 - nx test @typescript-eslint/utils --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/eslint-plugin --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/parser
• Node 18 - nx test @typescript-eslint/eslint-plugin-tslint
• Node 18 - nx test @typescript-eslint/eslint-plugin-internal
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/ast-spec
• Node 14 - nx test @typescript-eslint/ast-spec --coverage=false
• Node 18 - nx test @typescript-eslint/eslint-plugin
• Node 14 - nx test @typescript-eslint/scope-manager --coverage=false
• Node 18 - nx test @typescript-eslint/type-utils
• Node 18 - nx test @typescript-eslint/scope-manager
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/eslint-plugin-internal --coverage=false
• Node 14 - nx test @typescript-eslint/visitor-keys --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/type-utils --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website

---

Sent with 💌 from NxCloud.

[typescript-eslint]

Thanks for the PR, @snewcomer!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	f92cefd
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6369892a4ef328000850035b
😎 Deploy Preview	https://deploy-preview-5050--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[snewcomer]

Fixing a bug with inlining to a value ImportDefaultSpecifier....leaving in draft

[snewcomer]

Just a small fYI. Looks like the ember.js repo with this fixer ran on it works.

emberjs/ember.js#20101

[JoshuaKGoldberg]

This PR looks very snazzy and great at first glance, thanks for sending it! I just want to confirm with @bradzacher that it's not doing more than it should? (I suspect the part of the fixer that merges imports together is not needed)

[JoshuaKGoldberg]

Awesome - thanks so much for iterating on this with us @snewcomer! I'm pumped to get this shipped 😄

addressed

[ysulyma]

Can this be removed from the docs (https://typescript-eslint.io/rules/consistent-type-imports/#fixstyle) until it is released? I just spent several minutes troubleshooting

Error: .eslintrc.json:
	Configuration for rule "@typescript-eslint/consistent-type-imports" is invalid:
	Value {"fixStyle":"inline-type-imports"} should NOT have additional properties.

[JoshuaKGoldberg]

@ysulyma sorry about that - please see #5939