feat(eslint-plugin): [space-infix-ops] missing error report for conditional types

[holazz]

PR Checklist

• Addresses an existing open issue: fixes Bug: [space-infix-ops] Missing error report for conditional types #5033
• That issue was marked as accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2064bcd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 47 targets

• nx run-many --target=build --all --parallel --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/utils
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/visitor-keys
• Node 18 - nx test @typescript-eslint/eslint-plugin-tslint
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/type-utils
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=typecheck --all --parallel
• Node 12 - nx test @typescript-eslint/type-utils --coverage=false
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/scope-manager
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx test @typescript-eslint/eslint-plugin-tslint --coverage=false
• Node 12 - nx test @typescript-eslint/ast-spec --coverage=false
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/typescript-estree
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/ast-spec
• Node 12 - nx test @typescript-eslint/scope-manager --coverage=false
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx test @typescript-eslint/eslint-plugin --coverage=false
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/eslint-plugin-internal
• Node 12 - nx test @typescript-eslint/visitor-keys --coverage=false
• Node 12 - nx test @typescript-eslint/eslint-plugin-internal --coverage=false
• Node 12 - nx test @typescript-eslint/parser --coverage=false
• Node 18 - nx test @typescript-eslint/eslint-plugin
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/parser
• Node 12 - nx test @typescript-eslint/utils --coverage=false
• Node 12 - nx test @typescript-eslint/typescript-estree --coverage=false
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website

---

Sent with 💌 from NxCloud.

[typescript-eslint]

Thanks for the PR, @holazz!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	2064bcd
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/628f965bf035490008392a93
😎 Deploy Preview	https://deploy-preview-5041--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[bradzacher]

Thanks for this!

We've found reusing selectors like this is very brittle and can easily break!

Instead of hacking the AST to reuse their internal code - let's just fork their logic - it'll be less lines and it'll mean we are better able to modify it in future if we need.

[holazz]

Thanks for this!

We've found reusing selectors like this is very brittle and can easily break!

Instead of hacking the AST to reuse their internal code - let's just fork their logic - it'll be less lines and it'll mean we are better able to modify it in future if we need.

Sorry, I saw some such usage in the source code, I thought it was intentional. I have changed it, please review it.

[holazz]

is there any status update on this? 🤔

[JoshuaKGoldberg]

Code looks good, just hoping for some more tests. 🙂

[holazz]

@JoshuaKGoldberg I added some more test cases, please review!

[JoshuaKGoldberg]

Yup, looks great. Thanks for the fix!