fix(ast-spec): add SpreadElement to ArrayExpression.elements

[Josh-Cena]

PR Checklist

• Addresses an existing open issue: fixes ArrayExpression does not include SpreadElement as possible value of elements property #4963
• That issue was marked as accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

[typescript-eslint]

Thanks for the PR, @Josh-Cena!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[netlify]

👷 Deploy request for typescript-eslint pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	6967973

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6967973. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 47 targets

• Node 18 - nx test @typescript-eslint/eslint-plugin
• Node 12 - nx test @typescript-eslint/eslint-plugin --coverage=false
• nx run-many --target=build --all --parallel --exclude website
• Node 12 - nx test @typescript-eslint/typescript-estree --coverage=false
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/visitor-keys
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/typescript-estree
• Node 18 - nx test @typescript-eslint/type-utils
• Node 18 - nx test @typescript-eslint/utils
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=typecheck --all --parallel
• Node 12 - nx test @typescript-eslint/scope-manager --coverage=false
• Node 18 - nx test @typescript-eslint/scope-manager
• Node 12 - nx test @typescript-eslint/visitor-keys --coverage=false
• Node 12 - nx test @typescript-eslint/utils --coverage=false
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/ast-spec
• Node 12 - nx test @typescript-eslint/parser --coverage=false
• Node 12 - nx test @typescript-eslint/eslint-plugin-internal --coverage=false
• Node 18 - nx test @typescript-eslint/eslint-plugin-internal
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx test @typescript-eslint/eslint-plugin-tslint --coverage=false
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/eslint-plugin-tslint
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/parser
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx test @typescript-eslint/type-utils --coverage=false
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx test @typescript-eslint/ast-spec --coverage=false
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website

---

Sent with 💌 from NxCloud.

[codecov]

Codecov Report

Merging #5025 (6967973) into main (7e7b24c) will increase coverage by 0.38%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5025      +/-   ##
==========================================
+ Coverage   91.32%   91.71%   +0.38%     
==========================================
  Files         132      361     +229     
  Lines        1487    12124   +10637     
  Branches      224     3518    +3294     
==========================================
+ Hits         1358    11119    +9761     
- Misses         65      657     +592     
- Partials       64      348     +284     

Flag	Coverage Δ
unittest	91.71% <ø> (+0.38%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...int-plugin/src/rules/require-array-sort-compare.ts	88.23% <0.00%> (ø)
...ckages/eslint-plugin/src/rules/no-magic-numbers.ts	80.64% <0.00%> (ø)
...kages/eslint-plugin/src/rules/no-base-to-string.ts	98.41% <0.00%> (ø)
packages/eslint-plugin/src/configs/strict.ts	100.00% <0.00%> (ø)
...es/eslint-plugin/src/rules/no-duplicate-imports.ts	97.67% <0.00%> (ø)
packages/utils/src/ts-eslint/index.ts	11.11% <0.00%> (ø)
packages/eslint-plugin-tslint/src/custom-linter.ts	100.00% <0.00%> (ø)
packages/visitor-keys/src/visitor-keys.ts	100.00% <0.00%> (ø)
packages/eslint-plugin/src/util/objectIterators.ts	66.66% <0.00%> (ø)
packages/eslint-plugin/src/rules/ban-types.ts	100.00% <0.00%> (ø)
... and 219 more

[JoshuaKGoldberg]

I'll defer to @bradzacher here because of the recent work with snapshots. But this LGTM in general!

[bradzacher]

This is correct.
We won't require any one add snapshots for changes until the migration is finished.
There are still a few bits that might need some ironing out

[bradzacher]

thanks!