New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin): [member-delimiter-style] autofixer result is not as expected with option delimiter: 'none'
#5023
fix(eslint-plugin): [member-delimiter-style] autofixer result is not as expected with option delimiter: 'none'
#5023
Conversation
…as expected with option `delimiter: 'none'`
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Thanks for the PR, @holazz! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## main #5023 +/- ##
==========================================
+ Coverage 91.32% 93.79% +2.46%
==========================================
Files 132 286 +154
Lines 1487 9795 +8308
Branches 224 2930 +2706
==========================================
+ Hits 1358 9187 +7829
- Misses 65 328 +263
- Partials 64 280 +216
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sending the issue & PR, always appreciated! ❤️🔥
Marking as blocked pending more info in #5022. As much as we love contributions, we recommend waiting till issues are marked as accepting PRs before sending in code to make sure we can accept the contribution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thanks! This fix looks perfect. 💯
autofixer result is not as expected with option
delimiter: 'none'
PR Checklist
delimiter: 'none'
#5022Overview