New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin): [prefer-readonly] correct issue with anonymus functions #4974
fix(eslint-plugin): [prefer-readonly] correct issue with anonymus functions #4974
Conversation
Thanks for the PR, @armano2! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## main #4974 +/- ##
==========================================
+ Coverage 91.32% 93.79% +2.46%
==========================================
Files 132 286 +154
Lines 1487 9797 +8310
Branches 224 2931 +2707
==========================================
+ Hits 1358 9189 +7831
- Misses 65 328 +263
- Partials 64 280 +216
Flags with carried forward coverage won't be shown. Click here to find out more.
|
PR Checklist
Overview
this seem like issue with types produced by typescript
for code typescript returns us IntersectionType without symbol instead of ObjectType
in typeFlags we are receiving
Intersection = 2097152
instead ofObject = 524288
, we can simply fix it by adding handling to this case,microsoft/TypeScript#49116