fix(ast-spec): correct AwaitExpression.argument type

[ddubrava]

PR Checklist

• Addresses an existing open issue: fixes AwaitExpression does not include ImportExpression as possible value of argument property #4877
• That issue was marked as accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

ImportExpression is added to LeftHandSideExpression.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d66baab. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 43 targets

• Node 16.x - nx test @typescript-eslint/eslint-plugin-tslint
• Node 16.x - nx test @typescript-eslint/eslint-plugin
• Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
• Node 12.x - nx test @typescript-eslint/eslint-plugin
• Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint
• Node 14.x - nx test @typescript-eslint/eslint-plugin
• Node 12.x - nx test @typescript-eslint/eslint-plugin-internal
• Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
• Node 12.x - nx test @typescript-eslint/eslint-plugin
• Node 16.x - nx test @typescript-eslint/parser
• Node 14.x - nx test @typescript-eslint/parser
• Node 16.x - nx test @typescript-eslint/type-utils
• Node 14.x - nx test @typescript-eslint/type-utils
• Node 16.x - nx test @typescript-eslint/utils
• Node 14.x - nx test @typescript-eslint/utils
• Node 16.x - nx test @typescript-eslint/scope-manager
• Node 14.x - nx test @typescript-eslint/scope-manager
• Node 12.x - nx test @typescript-eslint/parser
• Node 12.x - nx test @typescript-eslint/type-utils
• Node 12.x - nx test @typescript-eslint/utils
• Node 12.x - nx test @typescript-eslint/scope-manager
• Node 14.x - nx test @typescript-eslint/visitor-keys
• Node 14.x - nx test @typescript-eslint/typescript-estree
• Node 16.x - nx test @typescript-eslint/visitor-keys
• Node 16.x - nx test @typescript-eslint/typescript-estree
• Node 12.x - nx test @typescript-eslint/visitor-keys
• Node 12.x - nx test @typescript-eslint/typescript-estree
• Node 12.x - nx test @typescript-eslint/parser
• Node 12.x - nx test @typescript-eslint/type-utils
• Node 12.x - nx test @typescript-eslint/utils
• Node 12.x - nx test @typescript-eslint/scope-manager --code-coverage
• Node 12.x - nx test @typescript-eslint/visitor-keys
• Node 12.x - nx test @typescript-eslint/typescript-estree
• Node 12.x - nx run-many --target=build --all --parallel --exclude website
• Node 12.x - nx run-many --target=typecheck --all --parallel
• Node 14.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 16.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx run-many --target=build --all --parallel --exclude website
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website

---

Sent with 💌 from NxCloud.

[typescript-eslint]

Thanks for the PR, @ddubrava!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	d66baab
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/626c503e28118f00096d11e5
😎 Deploy Preview	https://deploy-preview-4880--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[codecov]

Codecov Report

Merging #4880 (d66baab) into main (63fbbaa) will decrease coverage by 0.70%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4880      +/-   ##
==========================================
- Coverage   92.49%   91.78%   -0.71%     
==========================================
  Files         346      228     -118     
  Lines       11684    10633    -1051     
  Branches     3335     3290      -45     
==========================================
- Hits        10807     9760    -1047     
+ Misses        608      591      -17     
- Partials      269      282      +13     

Flag	Coverage Δ
unittest	91.78% <100.00%> (-0.71%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...gin/src/rules/non-nullable-type-assertion-style.ts	100.00% <100.00%> (ø)
packages/utils/src/json-schema.ts	5.55% <0.00%> (-94.45%)	⬇️
packages/utils/src/ts-eslint/index.ts	11.11% <0.00%> (-88.89%)	⬇️
packages/utils/src/eslint-utils/index.ts	12.50% <0.00%> (-87.50%)	⬇️
packages/utils/src/ts-eslint-scope/index.ts	18.18% <0.00%> (-81.82%)	⬇️
packages/utils/src/ts-eslint/ParserOptions.ts	20.00% <0.00%> (-80.00%)	⬇️
packages/utils/src/ast-utils/eslint-utils/index.ts	20.00% <0.00%> (-80.00%)	⬇️
packages/utils/src/ast-utils/index.ts	25.00% <0.00%> (-75.00%)	⬇️
packages/typescript-estree/src/ts-estree/index.ts	50.00% <0.00%> (-50.00%)	⬇️
packages/eslint-plugin/src/util/astUtils.ts	83.33% <0.00%> (-5.56%)	⬇️
... and 223 more

[bradzacher]

Sorry, I realised that I was very wrong when I wrote that comment. I wasn't thinking right.

Our types for AwaitExpression are very wrong.

https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/ast-spec/src/expression/AwaitExpression/spec.ts#L9

This type should just be Expression, not a custom union.

[ddubrava]

If you prefer force pushing here let me know. as according to your contributing.md, there is a request not to force push

[bradzacher]

Brilliant - thanks for fixing this!