fix(eslint-plugin): [space-infix-ops] fix no error when right type is function #4848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is function No errors were thrown when the right type is a function when no space between union or intersection operator. Function types are wrapped inside parenthesize. If the right type is function, instead of getting the operator, it was always getting the function parenthesize. The fix providedd skips wrapped parenthesize for function type, so that operator will be properly identified.
|
Thanks for the PR, @tapanprakasht! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## main #4848 +/- ##
=======================================
Coverage 94.23% 94.24%
=======================================
Files 152 152
Lines 8281 8283 +2
Branches 2694 2696 +2
=======================================
+ Hits 7804 7806 +2
Misses 263 263
Partials 214 214
Flags with carried forward coverage won't be shown. Click here to find out more.
|
JoshuaKGoldberg
requested changes
Apr 22, 2022
There was a problem hiding this comment.
Looks great, thanks @tapanprakasht! Just one request around added tests for edge cases and we should be good to go! 🚀
JoshuaKGoldberg
added
the
awaiting response
JoshuaKGoldberg
approved these changes
Apr 24, 2022
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
May 1, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.20.0` -> `5.21.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.20.0/5.21.0) | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.20.0` -> `5.21.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.20.0/5.21.0) | --- ### Release Notes <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin)</summary> ### [`v5.21.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#​5210-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5200v5210-2022-04-25) [Compare Source](typescript-eslint/typescript-eslint@v5.20.0...v5.21.0) ##### Bug Fixes - **eslint-plugin:** \[no-misused-promises] prioritize false returns when checking whether a function returns only void ([#​4841](typescript-eslint/typescript-eslint#4841)) ([ccadb60](typescript-eslint/typescript-eslint@ccadb60)) - **eslint-plugin:** \[no-namespace] fix false positive for exported namespaces when allowDeclarations=true ([#​4844](typescript-eslint/typescript-eslint#4844)) ([4e7c9be](typescript-eslint/typescript-eslint@4e7c9be)) - **eslint-plugin:** \[space-infix-ops] fix no error when right type is function ([#​4848](typescript-eslint/typescript-eslint#4848)) ([d74d559](typescript-eslint/typescript-eslint@d74d559)) ##### Features - **eslint-plugin:** \[parameter-properties] add rule to replace `no-parameter-properties` ([#​4622](typescript-eslint/typescript-eslint#4622)) ([88ed9ec](typescript-eslint/typescript-eslint@88ed9ec)) </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/parser)</summary> ### [`v5.21.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#​5210-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5200v5210-2022-04-25) [Compare Source](typescript-eslint/typescript-eslint@v5.20.0...v5.21.0) **Note:** Version bump only for package [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1319 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Overview
No errors were thrown when the right type is a function when no space between union or intersection operator. Function types are wrapped inside parenthesis. If the right type is a function, instead of getting the operator, it was always getting the wrapper parenthesis. The fix provided is to skips wrapped parenthesis for function type, so that
an operator will be properly identified.