New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(typescript-estree): extends
constraints for infer
#4830
Conversation
Thanks for the PR, @sosukesuzuki! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
extends
constraints for infer
extends
constraints for infer
a87ec29
to
cfd7944
Compare
i merged the version bump so this can be rebased on top of main |
cfd7944
to
ee82630
Compare
ee82630
to
97a7626
Compare
Codecov Report
@@ Coverage Diff @@
## main #4830 +/- ##
==========================================
- Coverage 91.76% 91.75% -0.01%
==========================================
Files 229 227 -2
Lines 10635 10628 -7
Branches 3293 3293
==========================================
- Hits 9759 9752 -7
Misses 592 592
Partials 284 284
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is awesome that it was already supported!
PR Checklist
Overview
Based on #4829
According to TS Compiler AST, add the
constraints
field to theTSTypeParameter
, not theTSInferType
. so This PR just adds tests( a87ec29 ).