Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript-estree): extends constraints for infer #4830

Merged
merged 1 commit into from May 17, 2022

Conversation

sosukesuzuki
Copy link
Contributor

@sosukesuzuki sosukesuzuki commented Apr 17, 2022

PR Checklist

Overview

Based on #4829

According to TS Compiler AST, add the constraints field to the TSTypeParameter, not the TSInferType. so This PR just adds tests( a87ec29 ).

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @sosukesuzuki!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@nx-cloud
Copy link

nx-cloud bot commented Apr 17, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 97a7626. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 43 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Apr 17, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 97a7626
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6283bb228f62810008d11a52
😎 Deploy Preview https://deploy-preview-4830--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sosukesuzuki sosukesuzuki changed the title feat: extends constraints for infer feat(typescript-estree): extends constraints for infer Apr 17, 2022
@bradzacher bradzacher added the AST PRs and Issues about the AST structure label Apr 25, 2022
@bradzacher
Copy link
Member

i merged the version bump so this can be rebased on top of main

@sosukesuzuki sosukesuzuki marked this pull request as ready for review May 17, 2022 15:12
@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #4830 (97a7626) into main (f256357) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4830      +/-   ##
==========================================
- Coverage   91.76%   91.75%   -0.01%     
==========================================
  Files         229      227       -2     
  Lines       10635    10628       -7     
  Branches     3293     3293              
==========================================
- Hits         9759     9752       -7     
  Misses        592      592              
  Partials      284      284              
Flag Coverage Δ
unittest 91.75% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/configs/strict.ts 100.00% <ø> (ø)
packages/visitor-keys/src/visitor-keys.ts
packages/visitor-keys/src/get-keys.ts

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome that it was already supported!

@bradzacher bradzacher merged commit 8cbbcc3 into typescript-eslint:main May 17, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
AST PRs and Issues about the AST structure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants