Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New internal lint rule: use ESTree node ranges instead of TypeScript #4796

Open
JoshuaKGoldberg opened this issue Apr 8, 2022 · 1 comment
Open

New internal lint rule: use ESTree node ranges instead of TypeScript #4796

JoshuaKGoldberg opened this issue Apr 8, 2022 · 1 comment
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@JoshuaKGoldberg
Copy link
Member

Overview

Following #4723 and #4790, it looks like we need to might need to always report fixer ranges using the ES tree nodes rather than TypeScript nodes. If that's the case (is it?) we should lint to make sure we don't accidentally use a TypeScript node.
@JoshuaKGoldberg JoshuaKGoldberg added repo maintenance things to do with maintenance of the repo, and not with code/docs triage Waiting for maintainers to take a look labels Apr 8, 2022
@bradzacher bradzacher added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for maintainers to take a look labels Apr 9, 2022
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Nov 12, 2022
Open
@JoshuaKGoldberg
Copy link
Member Author

Also opened eslint-community/eslint-plugin-eslint-plugin#328. If that's accepted, we can close this issue & defer to eslint-plugin-eslint-plugin.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jan 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JoshuaKGoldberg @bradzacher