fix(visitor-keys): add missing visitor keys

[DMartens]

PR Checklist

• Addresses an existing issue: fixes Missing visitor keys #4724
• That issue was marked as accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

This adds the missing visitor keys mentioned in the issue #4724.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a3bf508. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 43 targets

• Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
• Node 12.x - nx test @typescript-eslint/eslint-plugin
• Node 12.x - nx test @typescript-eslint/eslint-plugin-internal
• Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
• Node 12.x - nx test @typescript-eslint/eslint-plugin
• Node 16.x - nx test @typescript-eslint/eslint-plugin-tslint
• Node 16.x - nx test @typescript-eslint/eslint-plugin
• Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint
• Node 14.x - nx test @typescript-eslint/eslint-plugin
• Node 12.x - nx test @typescript-eslint/parser
• Node 12.x - nx test @typescript-eslint/parser
• Node 12.x - nx test @typescript-eslint/type-utils
• Node 12.x - nx test @typescript-eslint/type-utils
• Node 12.x - nx test @typescript-eslint/utils
• Node 12.x - nx test @typescript-eslint/utils
• Node 12.x - nx test @typescript-eslint/scope-manager
• Node 12.x - nx test @typescript-eslint/scope-manager
• Node 12.x - nx test @typescript-eslint/visitor-keys
• Node 12.x - nx test @typescript-eslint/visitor-keys
• Node 16.x - nx test @typescript-eslint/parser
• Node 12.x - nx test @typescript-eslint/typescript-estree
• Node 12.x - nx test @typescript-eslint/typescript-estree
• Node 14.x - nx test @typescript-eslint/parser
• Node 16.x - nx test @typescript-eslint/type-utils
• Node 14.x - nx test @typescript-eslint/type-utils
• Node 16.x - nx test @typescript-eslint/utils
• Node 14.x - nx test @typescript-eslint/utils
• Node 16.x - nx test @typescript-eslint/scope-manager
• Node 14.x - nx test @typescript-eslint/scope-manager
• Node 14.x - nx test @typescript-eslint/visitor-keys
• Node 14.x - nx test @typescript-eslint/typescript-estree
• Node 16.x - nx test @typescript-eslint/visitor-keys
• Node 16.x - nx test @typescript-eslint/typescript-estree
• Node 12.x - nx run-many --target=typecheck --all --parallel
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx run-many --target=build --all --parallel --exclude website
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx run-many --target=build --all --parallel --exclude website
• Node 16.x - nx run-many --target=build --all --parallel --exclude website --exclude website

---

Sent with 💌 from NxCloud.

[typescript-eslint]

Thanks for the PR, @DMartens!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	a3bf508
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6242f4c7258bd20008ea3ab0
😎 Deploy Preview	https://deploy-preview-4731--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[bradzacher]

Thanks for this!
Some of these are good to go.

However we should remove the following:

• TSModuleDeclaration - modifiers
• TSEnumDeclaration - modifiers
• TSInterfaceDeclaration - implements

I've filed #4759 - we should remove these from the AST in the next major.

the others are all valid bugs that are missing!

[bradzacher]

LGTM - thanks for adding these!