feat(eslint-plugin): [no-this-alias] report on assignment expressions

[juank1809]

PR Checklist

• Addresses an existing issue: fixes [no-this-alias] does not detect all cases of aliasing this to local variable #4690
• That issue was marked as accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

The rule 'no-this-alias' had no logic of how to manage a reassignment of a variable already declared, it was only working in a variable declaration. This code adds an AssignmentExpression node to be handled and grabs the id of the Identifier of either AssigmentExpression or VariableDeclarator.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 84cef31. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 43 targets

• Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
• Node 12.x - nx test @typescript-eslint/eslint-plugin
• Node 16.x - nx test @typescript-eslint/eslint-plugin-tslint
• Node 12.x - nx test @typescript-eslint/eslint-plugin-internal
• Node 16.x - nx test @typescript-eslint/eslint-plugin
• Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
• Node 12.x - nx test @typescript-eslint/eslint-plugin
• Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint
• Node 14.x - nx test @typescript-eslint/eslint-plugin
• Node 12.x - nx run-many --target=typecheck --all --parallel
• Node 12.x - nx run-many --target=build --all --parallel --exclude website
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx test @typescript-eslint/parser
• Node 12.x - nx test @typescript-eslint/type-utils
• Node 12.x - nx test @typescript-eslint/utils
• Node 12.x - nx test @typescript-eslint/scope-manager
• Node 12.x - nx test @typescript-eslint/visitor-keys
• Node 12.x - nx test @typescript-eslint/typescript-estree
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx run-many --target=build --all --parallel --exclude website
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14.x - nx test @typescript-eslint/parser
• Node 14.x - nx test @typescript-eslint/type-utils
• Node 14.x - nx test @typescript-eslint/utils
• Node 14.x - nx test @typescript-eslint/scope-manager
• Node 14.x - nx test @typescript-eslint/visitor-keys
• Node 14.x - nx test @typescript-eslint/typescript-estree
• Node 14.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx test @typescript-eslint/parser
• Node 12.x - nx test @typescript-eslint/type-utils
• Node 12.x - nx test @typescript-eslint/utils
• Node 12.x - nx test @typescript-eslint/scope-manager
• Node 16.x - nx test @typescript-eslint/parser
• Node 12.x - nx test @typescript-eslint/visitor-keys
• Node 16.x - nx test @typescript-eslint/type-utils
• Node 12.x - nx test @typescript-eslint/typescript-estree
• Node 16.x - nx test @typescript-eslint/utils
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 16.x - nx test @typescript-eslint/scope-manager
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 16.x - nx test @typescript-eslint/visitor-keys
• Node 16.x - nx test @typescript-eslint/typescript-estree
• Node 16.x - nx run-many --target=build --all --parallel --exclude website --exclude website

---

Sent with 💌 from NxCloud.

[typescript-eslint]

Thanks for the PR, @juank1809!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[netlify]

❌ Deploy Preview for typescript-eslint failed.

Name	Link
🔨 Latest commit	84cef31
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/623fa7e1ec24040008e4836a

[codecov]

Codecov Report

Merging #4718 (84cef31) into main (d4768c0) will increase coverage by 7.41%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4718      +/-   ##
==========================================
+ Coverage   86.97%   94.39%   +7.41%     
==========================================
  Files           5      151     +146     
  Lines         215     8189    +7974     
  Branches       60     2645    +2585     
==========================================
+ Hits          187     7730    +7543     
- Misses         22      258     +236     
- Partials        6      201     +195     

Flag	Coverage Δ
unittest	94.39% <100.00%> (+7.41%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/eslint-plugin/src/rules/no-this-alias.ts	100.00% <100.00%> (ø)
...plugin-internal/src/rules/prefer-ast-types-enum.ts
...lugin-internal/src/rules/plugin-test-formatting.ts
...-internal/src/rules/no-typescript-estree-import.ts
...gin-internal/src/rules/no-poorly-typed-ts-props.ts
...internal/src/rules/no-typescript-default-import.ts
packages/eslint-plugin/src/rules/no-loop-func.ts	98.11% <0.00%> (ø)
...c/rules/no-non-null-asserted-nullish-coalescing.ts	91.66% <0.00%> (ø)
.../eslint-plugin/src/util/explicitReturnTypeUtils.ts	96.42% <0.00%> (ø)
...int-plugin/src/rules/require-array-sort-compare.ts	88.88% <0.00%> (ø)
... and 147 more

[JoshuaKGoldberg]

This makes sense, thanks for the change! I'm leaving some comments in the linked issue that might change things, so I'll defer to @bradzacher on merging.

[bradzacher]

this LGTM! Thanks for adding the extra handling!