feat: TypeScript 4.6

[sosukesuzuki]

PR Checklist

Sorry I have not created an issue for this.

• Addresses an existing issue: fixes TypeScript 4.6 Support #4471
• That issue was marked as accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

TypeScript 4.6 has been released:tada:

This PR updates typescript to 4.6.

Also, fixes some tests for typescript-estree to match the fixes on the TypeScript side.

[nx-cloud]

☁️ Nx Cloud Report

CI ran the following commands for commit 361c98f. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 52 targets

• Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
• Node 12.x - nx test @typescript-eslint/eslint-plugin
• Node 12.x - nx test @typescript-eslint/eslint-plugin-internal
• Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
• Node 12.x - nx test @typescript-eslint/eslint-plugin
• Node 16.x - nx test @typescript-eslint/eslint-plugin-tslint
• Node 16.x - nx test @typescript-eslint/eslint-plugin
• Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint
• Node 14.x - nx test @typescript-eslint/eslint-plugin
• Node 12.x - nx test @typescript-eslint/parser
• Node 12.x - nx test @typescript-eslint/type-utils
• Node 12.x - nx test @typescript-eslint/utils
• Node 12.x - nx test @typescript-eslint/scope-manager
• Node 12.x - nx test @typescript-eslint/visitor-keys
• Node 12.x - nx test @typescript-eslint/parser
• Node 12.x - nx test @typescript-eslint/typescript-estree
• Node 12.x - nx test @typescript-eslint/type-utils
• Node 12.x - nx test @typescript-eslint/utils
• Node 12.x - nx test @typescript-eslint/scope-manager
• Node 16.x - nx test @typescript-eslint/parser
• Node 14.x - nx test @typescript-eslint/parser
• Node 16.x - nx test @typescript-eslint/type-utils
• Node 12.x - nx run-many --target=typecheck --all --parallel
• Node 14.x - nx test @typescript-eslint/type-utils
• Node 16.x - nx test @typescript-eslint/utils
• Node 12.x - nx test @typescript-eslint/visitor-keys
• Node 12.x - nx test @typescript-eslint/typescript-estree
• Node 16.x - nx test @typescript-eslint/scope-manager
• Node 14.x - nx test @typescript-eslint/utils
• Node 14.x - nx test @typescript-eslint/scope-manager
• Node 14.x - nx test @typescript-eslint/visitor-keys
• Node 14.x - nx test @typescript-eslint/typescript-estree
• Node 16.x - nx test @typescript-eslint/visitor-keys
• Node 16.x - nx test @typescript-eslint/typescript-estree
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx run-many --target=build --all --parallel --exclude website
• Node 12.x - nx prebuild @typescript-eslint/types
• Node 12.x - nx run-many --target=build --all --parallel --exclude website
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 16.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx prebuild @typescript-eslint/types
• Node 12.x - nx prebuild @typescript-eslint/types
• Node 12.x - nx prebuild @typescript-eslint/types
• Node 12.x - nx prebuild @typescript-eslint/types
• Node 12.x - nx prebuild @typescript-eslint/types
• Node 12.x - nx prebuild @typescript-eslint/types
• Node 14.x - nx prebuild @typescript-eslint/types
• Node 16.x - nx prebuild @typescript-eslint/types

---

Sent with 💌 from NxCloud.

[typescript-eslint]

Thanks for the PR, @sosukesuzuki!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[netlify]

❌ Deploy Preview for typescript-eslint failed.

🔨 Explore the source changes: 361c98f

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/62215e001957f30008157a58

[codecov]

Codecov Report

Merging #4615 (361c98f) into main (4ed686f) will decrease coverage by 2.23%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4615      +/-   ##
==========================================
- Coverage   94.23%   92.00%   -2.24%     
==========================================
  Files         151      350     +199     
  Lines        7948    11621    +3673     
  Branches     2572     3375     +803     
==========================================
+ Hits         7490    10692    +3202     
- Misses        262      660     +398     
- Partials      196      269      +73     

Flag	Coverage Δ
unittest	92.00% <100.00%> (-2.24%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/scope-manager/src/lib/dom.iterable.ts	100.00% <ø> (ø)
packages/scope-manager/src/lib/dom.ts	100.00% <ø> (ø)
packages/scope-manager/src/lib/esnext.array.ts	100.00% <ø> (ø)
...ckages/scope-manager/src/lib/webworker.iterable.ts	100.00% <ø> (ø)
packages/scope-manager/src/lib/webworker.ts	100.00% <ø> (ø)
packages/scope-manager/src/lib/es2022.array.ts	100.00% <100.00%> (ø)
packages/scope-manager/src/lib/es2022.error.ts	100.00% <100.00%> (ø)
packages/scope-manager/src/lib/es2022.full.ts	100.00% <100.00%> (ø)
packages/scope-manager/src/lib/es2022.object.ts	100.00% <100.00%> (ø)
packages/scope-manager/src/lib/es2022.string.ts	100.00% <100.00%> (ø)
... and 196 more

[bradzacher]

Thanks for this! Could you also please run yarn generate:lib within typescript-estree?

typescript-eslint/packages/scope-manager/package.json

Line 36 in 3ea0947

"generate:lib": "../../node_modules/.bin/ts-node --files --transpile-only tools/generate-lib.ts",

[bradzacher]

We can also just bump the peer dep ranges as there's no new features to handle from our side (according to the change log)

[sosukesuzuki]

@bradzacher

We can also just bump the peer dep ranges as there's no new features to handle from our side (according to the change log)

Sorry what does "peer dep ranges" mean?

[bradzacher]

thanks for doing this!

[bradzacher]

OOPS! Missed your comment.

Sorry what does "peer dep ranges" mean?

Should just be this right here:

typescript-eslint/packages/typescript-estree/src/parser.ts

Line 33 in 56a09e9

const SUPPORTED_TYPESCRIPT_VERSIONS = '>=3.3.1 <4.6.0';

This is where we validate the TS version you're using. I forgot that we don't actually have a hard peer dependency range for TS in the package (they're all "*")

needs one change

[sosukesuzuki]

Why netlify on CI was failed..?

[bradzacher]

It's not your fault. The build is just flaky.

[bradzacher]

thanks for doing this!