Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [sort-type-union-intersection-members] Wrap the constructorType in parentheses #4590

Conversation

islandryu
Copy link
Contributor

@islandryu islandryu commented Feb 24, 2022

PR Checklist

Overview

The constructorType is now also enclosed in parentheses.

@nx-cloud
Copy link

nx-cloud bot commented Feb 24, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 5574e24. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 48 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @islandryu!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Feb 24, 2022

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: 5574e24

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/6217af1461ae770008f23ad8

😎 Browse the preview: https://deploy-preview-4590--typescript-eslint.netlify.app

@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #4590 (5574e24) into main (823b945) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4590      +/-   ##
==========================================
+ Coverage   94.62%   94.64%   +0.01%     
==========================================
  Files         149      150       +1     
  Lines        8072     8102      +30     
  Branches     2581     2590       +9     
==========================================
+ Hits         7638     7668      +30     
  Misses        239      239              
  Partials      195      195              
Flag Coverage Δ
unittest 94.64% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/configs/all.ts 100.00% <ø> (ø)
...ckages/eslint-plugin/src/util/getESLintCoreRule.ts 75.00% <ø> (ø)
...ackages/eslint-plugin/src/rules/member-ordering.ts 95.68% <100.00%> (+0.12%) ⬆️
.../src/rules/sort-type-union-intersection-members.ts 92.53% <100.00%> (+0.11%) ⬆️
...ges/eslint-plugin/src/rules/space-before-blocks.ts 100.00% <100.00%> (ø)

@islandryu islandryu force-pushed the fix/constructorTypeBeParenthesized branch from 3058575 to a481dd3 Compare February 24, 2022 09:10
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, LGTM. Thanks @islandryu!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 851bb90 into typescript-eslint:main Feb 24, 2022
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Mar 8, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.12.1` -> `5.13.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.12.1/5.13.0) |
| [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.12.1` -> `5.13.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.12.1/5.13.0) |

---

### Release Notes

<details>
<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>

### [`v5.13.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5130-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5121v5130-2022-02-28)

[Compare Source](typescript-eslint/typescript-eslint@v5.12.1...v5.13.0)

##### Bug Fixes

-   **eslint-plugin:** \[sort-type-union-intersection-members] Wrap the constructorType in parentheses ([#&#8203;4590](typescript-eslint/typescript-eslint#4590)) ([851bb90](typescript-eslint/typescript-eslint@851bb90))

##### Features

-   **eslint-plugin:** \[no-misused-promises] check more places for checksVoidReturn ([#&#8203;4541](typescript-eslint/typescript-eslint#4541)) ([052cf51](typescript-eslint/typescript-eslint@052cf51))
-   **eslint-plugin:** add `no-redundant-type-constituents` rule ([#&#8203;4378](typescript-eslint/typescript-eslint#4378)) ([63d051e](typescript-eslint/typescript-eslint@63d051e))
-   **eslint-plugin:** add `no-useless-empty-export` rule ([#&#8203;4380](typescript-eslint/typescript-eslint#4380)) ([823b945](typescript-eslint/typescript-eslint@823b945))
-   **eslint-plugin:** add extension rule `space-before-blocks` ([#&#8203;1606](typescript-eslint/typescript-eslint#1606)) ([#&#8203;4184](typescript-eslint/typescript-eslint#4184)) ([208b6d0](typescript-eslint/typescript-eslint@208b6d0))
-   **eslint-plugin:** added member group support to member-ordering rule ([#&#8203;4538](typescript-eslint/typescript-eslint#4538)) ([6afcaea](typescript-eslint/typescript-eslint@6afcaea))

#### [5.12.1](typescript-eslint/typescript-eslint@v5.12.0...v5.12.1) (2022-02-21)

##### Bug Fixes

-   **eslint-plugin:** \[no-unnecessary-type-arguments] fix comparison of types ([#&#8203;4555](typescript-eslint/typescript-eslint#4555)) ([fc3936e](typescript-eslint/typescript-eslint@fc3936e))

</details>

<details>
<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>

### [`v5.13.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5130-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5121v5130-2022-02-28)

[Compare Source](typescript-eslint/typescript-eslint@v5.12.1...v5.13.0)

**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)

#### [5.12.1](typescript-eslint/typescript-eslint@v5.12.0...v5.12.1) (2022-02-21)

**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Co-authored-by: 6543 <6543@noreply.codeberg.org>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1192
Reviewed-by: 6543 <6543@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sort-type-union-intersection-members] Autofixed type not equivalent to original type
2 participants