fix(eslint-plugin): [no-magic-numbers] fix invalid schema merging

[ddubrava]

PR Checklist

• Addresses an existing issue: fixes [no-magic-numbers] invalid schema merging causes error in eslint #4515
• That issue was marked as accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

baseRule.meta.schema is an array of object

As a result, it merges in this:

According to the approach from no-empty-function rule, we use Array.isArray and return the first element, otherwise the object

[nx-cloud]

☁️ Nx Cloud Report

CI ran the following commands for commit c6b546b. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 48 targets

• Node 16.x - nx test @typescript-eslint/eslint-plugin-tslint
• Node 16.x - nx test @typescript-eslint/eslint-plugin
• Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint
• Node 14.x - nx test @typescript-eslint/eslint-plugin
• Node 12.x - nx test @typescript-eslint/eslint-plugin-internal
• Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
• Node 12.x - nx test @typescript-eslint/eslint-plugin
• Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
• Node 12.x - nx test @typescript-eslint/eslint-plugin
• Node 12.x - nx run-many --target=typecheck --all --parallel
• Node 14.x - nx test @typescript-eslint/parser
• Node 14.x - nx test @typescript-eslint/type-utils
• Node 14.x - nx test @typescript-eslint/utils
• Node 14.x - nx test @typescript-eslint/scope-manager
• Node 16.x - nx test @typescript-eslint/parser
• Node 14.x - nx test @typescript-eslint/visitor-keys
• Node 16.x - nx test @typescript-eslint/type-utils
• Node 14.x - nx test @typescript-eslint/typescript-estree
• Node 16.x - nx test @typescript-eslint/utils
• Node 14.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 16.x - nx test @typescript-eslint/scope-manager
• Node 16.x - nx test @typescript-eslint/visitor-keys
• Node 16.x - nx test @typescript-eslint/typescript-estree
• Node 16.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx test @typescript-eslint/parser
• Node 12.x - nx test @typescript-eslint/type-utils
• Node 12.x - nx test @typescript-eslint/utils
• Node 12.x - nx test @typescript-eslint/scope-manager
• Node 12.x - nx test @typescript-eslint/visitor-keys
• Node 12.x - nx test @typescript-eslint/typescript-estree
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx test @typescript-eslint/parser
• Node 12.x - nx test @typescript-eslint/type-utils
• Node 12.x - nx test @typescript-eslint/utils
• Node 12.x - nx test @typescript-eslint/scope-manager
• Node 12.x - nx test @typescript-eslint/visitor-keys
• Node 12.x - nx test @typescript-eslint/typescript-estree
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14.x - nx prebuild @typescript-eslint/types
• Node 16.x - nx prebuild @typescript-eslint/types
• Node 12.x - nx prebuild @typescript-eslint/types
• Node 12.x - nx prebuild @typescript-eslint/types
• Node 12.x - nx prebuild @typescript-eslint/types
• Node 12.x - nx prebuild @typescript-eslint/types
• Node 12.x - nx prebuild @typescript-eslint/types

---

Sent with 💌 from NxCloud.

[typescript-eslint]

Thanks for the PR, @ddubrava!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[netlify]

❌ Deploy Preview for typescript-eslint failed.

🔨 Explore the source changes: c6b546b

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/62003ace83ea5b00079a6042

[codecov]

Codecov Report

Merging #4517 (c6b546b) into main (63fbbaa) will increase coverage by 2.06%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##             main    #4517      +/-   ##
==========================================
+ Coverage   92.49%   94.56%   +2.06%     
==========================================
  Files         346      147     -199     
  Lines       11684     7889    -3795     
  Branches     3335     2535     -800     
==========================================
- Hits        10807     7460    -3347     
+ Misses        608      234     -374     
+ Partials      269      195      -74     

Flag	Coverage Δ
unittest	94.56% <92.85%> (+2.06%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ckages/eslint-plugin/src/rules/no-magic-numbers.ts	82.69% <0.00%> (-1.63%)	⬇️
...gin/src/rules/non-nullable-type-assertion-style.ts	100.00% <100.00%> (ø)
packages/utils/src/eslint-utils/nullThrows.ts
packages/scope-manager/src/lib/es2017.object.ts
...ript-estree/src/create-program/createSourceFile.ts
packages/scope-manager/src/lib/es2017.string.ts
packages/type-utils/src/requiresQuoting.ts
packages/scope-manager/src/lib/esnext.symbol.ts
packages/scope-manager/src/ScopeManager.ts
packages/scope-manager/src/lib/dom.iterable.ts
... and 191 more

[bradzacher]

thanks for fixing this!