Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(utils): expose ast-utils' helpers #4503

Merged
merged 2 commits into from Feb 23, 2022

Conversation

MichaelDeBoey
Copy link
Contributor

Currently we're using a copy of isNodeOfType in eslint-plugin-testing-library.
https://github.com/testing-library/eslint-plugin-testing-library/blob/main/lib/node-utils/is-node-of-type.ts#L6-L11

As the extraction in this codebase was originally copied from eslint-plugin-testing-library (see #3677 & testing-library/eslint-plugin-testing-library#329), it seems logical to expose it here so other packages can use it whenever they want.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @MichaelDeBoey!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@nx-cloud
Copy link

nx-cloud bot commented Feb 1, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 59271d1. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 48 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Feb 1, 2022

❌ Deploy Preview for typescript-eslint failed.

🔨 Explore the source changes: 59271d1

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/6216aeac43b62e000767d953

@codecov
Copy link

codecov bot commented Feb 1, 2022

Codecov Report

Merging #4503 (59271d1) into main (0c63f26) will decrease coverage by 2.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4503      +/-   ##
==========================================
- Coverage   94.26%   92.17%   -2.10%     
==========================================
  Files         169      204      +35     
  Lines        9511     8860     -651     
  Branches     2973     2752     -221     
==========================================
- Hits         8966     8167     -799     
- Misses        322      484     +162     
+ Partials      223      209      -14     
Flag Coverage Δ
unittest 92.17% <100.00%> (-2.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/utils/src/ast-utils/index.ts 100.00% <100.00%> (ø)
packages/typescript-estree/src/node-utils.ts
packages/typescript-estree/src/convert.ts
...estree/src/create-program/createIsolatedProgram.ts
...pt-estree/src/create-program/createWatchProgram.ts
packages/typescript-estree/src/ts-estree/index.ts
...escript-estree/src/semantic-or-syntactic-errors.ts
...ges/typescript-estree/src/create-program/shared.ts
...pt-estree/src/ts-estree/estree-to-ts-node-types.ts
packages/typescript-estree/src/simple-traverse.ts
... and 60 more

@bradzacher bradzacher added the enhancement New feature or request label Feb 2, 2022
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, this is a good change. Thanks @MichaelDeBoey!

@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) February 23, 2022 22:01
@JoshuaKGoldberg
Copy link
Member

@bradzacher could I ask for your help merging please? 😄

@bradzacher
Copy link
Member

bradzacher commented Feb 23, 2022

yeah automerge won't work unless all the required signals are green.
The codecov signal is red because somehow this caused a 2% drop in coverage...? Wut.

So we just need to admin bypass instead of auto-merging

@bradzacher bradzacher merged commit f106e4b into typescript-eslint:main Feb 23, 2022
@MichaelDeBoey MichaelDeBoey deleted the patch-51 branch February 24, 2022 00:23
JoshuaKGoldberg pushed a commit to JoshuaKGoldberg/typescript-eslint that referenced this pull request Feb 27, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants