fix(eslint-plugin): [no-extra-semi] false negatives when used with eslint 8.3.0

[ota-meshi]

PR Checklist

• Addresses an existing issue: fixes #000
• That issue was marked as accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

This PR modifies to call the changed method name of the no-extra-semi core rule.

This issue was found while working on #4448.
#4448 (comment)

[typescript-eslint]

Thanks for the PR, @ota-meshi!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[nx-cloud]

☁️ Nx Cloud Report

CI ran the following commands for commit 69311fd. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 48 targets

• Node 16.x - nx test @typescript-eslint/eslint-plugin-tslint
• Node 16.x - nx test @typescript-eslint/eslint-plugin
• Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint
• Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
• Node 12.x - nx test @typescript-eslint/eslint-plugin
• Node 14.x - nx test @typescript-eslint/eslint-plugin
• Node 12.x - nx test @typescript-eslint/eslint-plugin-internal
• Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
• Node 12.x - nx test @typescript-eslint/eslint-plugin
• Node 14.x - nx test @typescript-eslint/parser
• Node 14.x - nx test @typescript-eslint/type-utils
• Node 14.x - nx test @typescript-eslint/utils
• Node 14.x - nx test @typescript-eslint/scope-manager
• Node 16.x - nx test @typescript-eslint/parser
• Node 12.x - nx test @typescript-eslint/parser
• Node 12.x - nx test @typescript-eslint/type-utils
• Node 12.x - nx test @typescript-eslint/utils
• Node 12.x - nx test @typescript-eslint/scope-manager
• Node 12.x - nx test @typescript-eslint/visitor-keys
• Node 12.x - nx test @typescript-eslint/typescript-estree
• Node 16.x - nx test @typescript-eslint/type-utils
• Node 12.x - nx test @typescript-eslint/parser
• Node 14.x - nx test @typescript-eslint/visitor-keys
• Node 14.x - nx test @typescript-eslint/typescript-estree
• Node 16.x - nx test @typescript-eslint/utils
• Node 12.x - nx test @typescript-eslint/type-utils
• Node 16.x - nx test @typescript-eslint/scope-manager
• Node 12.x - nx test @typescript-eslint/utils
• Node 12.x - nx test @typescript-eslint/scope-manager
• Node 12.x - nx run-many --target=typecheck --all --parallel
• Node 12.x - nx test @typescript-eslint/visitor-keys
• Node 12.x - nx test @typescript-eslint/typescript-estree
• Node 16.x - nx test @typescript-eslint/visitor-keys
• Node 16.x - nx test @typescript-eslint/typescript-estree
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 16.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx prebuild @typescript-eslint/types
• Node 16.x - nx prebuild @typescript-eslint/types
• Node 14.x - nx prebuild @typescript-eslint/types
• Node 12.x - nx prebuild @typescript-eslint/types
• Node 12.x - nx prebuild @typescript-eslint/types
• Node 12.x - nx prebuild @typescript-eslint/types
• Node 12.x - nx prebuild @typescript-eslint/types

---

Sent with 💌 from NxCloud.

[netlify]

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: 69311fd

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61e52fb5f3988300081094d3

😎 Browse the preview: https://deploy-preview-4458--typescript-eslint.netlify.app

[ota-meshi]

I need to include the #4448 change to fix the CI errors.

[ota-meshi]

I merged the main branch into this PR.

[WikiRik]

Will you enable the codepath additions from #4448 in here? Or will that happen in a third PR?

[codecov]

Codecov Report

Merging #4458 (69311fd) into main (e56f1e5) will decrease coverage by 2.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #4458      +/-   ##
==========================================
- Coverage   94.38%   92.38%   -2.01%     
==========================================
  Files         154      346     +192     
  Lines        8107    11633    +3526     
  Branches     2583     3308     +725     
==========================================
+ Hits         7652    10747    +3095     
- Misses        255      619     +364     
- Partials      200      267      +67     

Flag	Coverage Δ
unittest	92.38% <0.00%> (-2.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/eslint-plugin/src/rules/no-extra-semi.ts	54.54% <0.00%> (-12.13%)	⬇️
...src/definition/ImplicitGlobalVariableDefinition.ts	100.00% <0.00%> (ø)
packages/scope-manager/src/lib/es2019.object.ts	100.00% <0.00%> (ø)
packages/typescript-estree/src/version-check.ts	100.00% <0.00%> (ø)
...kages/scope-manager/src/referencer/ClassVisitor.ts	93.96% <0.00%> (ø)
packages/scope-manager/src/lib/webworker.ts	100.00% <0.00%> (ø)
packages/scope-manager/src/lib/es2021.weakref.ts	100.00% <0.00%> (ø)
...ges/scope-manager/src/definition/DefinitionType.ts	100.00% <0.00%> (ø)
packages/scope-manager/src/variable/index.ts	100.00% <0.00%> (ø)
packages/type-utils/src/getSourceFileOfNode.ts	0.00% <0.00%> (ø)
... and 183 more

[ota-meshi]

Will you enable the codepath additions from #4448 in here? Or will that happen in a third PR?

I will not add it in this PR. I think it needs a feature request.

[WikiRik]

So we need a feature request for the code you have added in the previous PR but commented out because you wanted to update the ESLint version here?

I think I might not have been clear enough in my previous message. I am just talking about un-commenting lines 714 and 715 of the eslint-rules typings file. Or is that not a working solution for #4444?

[ota-meshi]

For the same reason as #4448, I find it difficult to prevent loss of coverage for this PR.

[ota-meshi]

@WikiRik
Code Path Analysis has long existed as an API for ESLint.
https://eslint.org/docs/developer-guide/code-path-analysis

However, the rules provided by typescript-eslint do not currently have rules that use the API (directly), so no type definition is needed either.
For now the @typescript-eslint/no-invalid-this rule doesn't even have to use it directly.

If you want to create a rule that uses Code Path Analysis and want to use the type definition provided by typescript-eslint, you'll need to request a feature.

[WikiRik]

Ah, so if I understand correctly it's not part of the solution for #4444. Then it's all good to me. Thanks for your work on these issues!

[bradzacher]

@WikiRik we don't need to worry about doing anything to the extension rule. The new code-path analysis selectors do not change the overrides we need to apply.

If it did - then the tests would be failing, which they are not.

In a nuttshell - previously the rule used explicit node selectors on things like functions to trigger the analysis. Our extension rule didn't touch that logic - it just augmented it so it could track this parameters and prevent the rule's ThisExpression selector appropriately.

Now the base rule uses the codepath selectors instead, but the overall logic doesn't change, thus nothing to change on our end aside from making sure we don't call undefined functions.