New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin): [no-invalid-this] crash when used with eslint 8.7.0 #4448
Conversation
Thanks for the PR, @ota-meshi! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
❌ Deploy Preview for typescript-eslint failed. 🔨 Explore the source changes: bb42059 🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61e527a619500d000796619a |
The |
@ota-meshi - feel free to fix it in this PR as well for ease of updating. |
I reverted the version of eslint to make it easier to merge this PR. |
Codecov Report
@@ Coverage Diff @@
## main #4448 +/- ##
==========================================
- Coverage 94.62% 94.57% -0.06%
==========================================
Files 147 147
Lines 7849 7849
Branches 2511 2515 +4
==========================================
- Hits 7427 7423 -4
Misses 233 233
- Partials 189 193 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
I find it difficult for me to prevent a loss of coverage as the code covered changes with each version of eslint 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this!
….0 (typescript-eslint#4448) * fix(eslint-plugin): [no-invalid-this] crash when used with eslint 8.7.0 * revert eslint version
PR Checklist
Overview
Changed not to call the deleted method to prevent the
no-invalid-this
rule from crashing. As far as I can see the implementation of the core rule, I think it works fine.