Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(type-utils): check IndexSignature internals when checking isTypeReadonly #4417

Merged
merged 9 commits into from Jan 17, 2022

Conversation

RebeccaStevens
Copy link
Contributor

PR Checklist

Overview

isTypeReadonly now checks the details of an IndexSignature; not just the outer readonlyness.

Note: This PR builds off #4416

@nx-cloud
Copy link

nx-cloud bot commented Jan 9, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 186756a. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 48 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @RebeccaStevens!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Jan 9, 2022

❌ Deploy Preview for typescript-eslint failed.

🔨 Explore the source changes: 186756a

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61e523a508b7610007a53db2

@RebeccaStevens RebeccaStevens marked this pull request as ready for review January 10, 2022 12:55
@RebeccaStevens RebeccaStevens marked this pull request as draft January 10, 2022 12:57
@bradzacher bradzacher added the bug Something isn't working label Jan 11, 2022
@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Jan 17, 2022
@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Jan 17, 2022
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this!

@bradzacher bradzacher merged commit ef3147c into typescript-eslint:main Jan 17, 2022
@RebeccaStevens RebeccaStevens deleted the issue-3714 branch January 17, 2022 09:11
lonyele pushed a commit to lonyele/typescript-eslint that referenced this pull request Feb 12, 2022
…eadonly (typescript-eslint#4417)

* fix(type-utils): make isTypeReadonly's options param optional

fix typescript-eslint#4410

* test(type-utils): add basic tests for isTypeReadonly

* test(type-utils): add test for IndexSignature internals

* fix(type-utils): check IndexSignature internals when checking isTypeReadonly

fix typescript-eslint#3714

* perf(type-utils): don't test IndexSignature key for readonlyness as it will always be readonly

Co-authored-by: Josh Goldberg <joshuakgoldberg@outlook.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[prefer-readonly-parameter-types] IndexSignature internals don't violate the rule
2 participants