Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [consistent-type-definitions] correct fixer with declare keyword #4334

Merged
merged 1 commit into from Dec 21, 2021

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Dec 20, 2021

PR Checklist

Overview

Fixer incorrectly changes declare keyword to interface

@armano2 armano2 added bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin labels Dec 20, 2021
@armano2 armano2 self-assigned this Dec 20, 2021
@nx-cloud
Copy link

nx-cloud bot commented Dec 20, 2021

☁️ Nx Cloud Report

CI ran the following commands for commit 8b4288a. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 44 targets

Sent with 💌 from NxCloud.

@typescript-eslint

This comment has been minimized.

@netlify
Copy link

netlify bot commented Dec 20, 2021

❌ Deploy Preview for typescript-eslint failed.

🔨 Explore the source changes: 8b4288a

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61c0fa45d8c444000897bf3a

@codecov
Copy link

codecov bot commented Dec 20, 2021

Codecov Report

Merging #4334 (8b4288a) into main (c3e1834) will increase coverage by 0.67%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4334      +/-   ##
==========================================
+ Coverage   93.52%   94.20%   +0.67%     
==========================================
  Files         336      152     -184     
  Lines       11596     8104    -3492     
  Branches     3291     2592     -699     
==========================================
- Hits        10845     7634    -3211     
+ Misses        479      266     -213     
+ Partials      272      204      -68     
Flag Coverage Δ
unittest 94.20% <100.00%> (+0.67%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nt-plugin/src/rules/consistent-type-definitions.ts 97.29% <100.00%> (ø)
...es/scope-manager/src/scope/ConditionalTypeScope.ts
packages/scope-manager/src/scope/SwitchScope.ts
...l-utils/src/ast-utils/eslint-utils/astUtilities.ts
...rimental-utils/src/ast-utils/eslint-utils/index.ts
packages/scope-manager/src/lib/es2020.intl.ts
...ges/experimental-utils/src/ast-utils/predicates.ts
...scope-manager/src/definition/VariableDefinition.ts
...s/scope-manager/src/scope/ClassStaticBlockScope.ts
packages/typescript-estree/src/ast-converter.ts
... and 175 more

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) December 21, 2021 08:43
@bradzacher bradzacher merged commit 0cd911a into main Dec 21, 2021
@bradzacher bradzacher deleted the fix/consistent-type-definitions-declare-fixer branch December 21, 2021 20:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[consistent-type-definitions] invalid fixer for declare type
3 participants