Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): ignore all whitespaces in comparison #4223

Merged
merged 1 commit into from Nov 26, 2021

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Nov 26, 2021

PR Checklist

Overview

While comparing types exclude all white-spaces

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Nov 26, 2021

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: c594102

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61a0924958c9350008424900

😎 Browse the preview: https://deploy-preview-4223--typescript-eslint.netlify.app

@armano2 armano2 changed the title fix(eslint-plugin): remove all whitespaces in comparison #4220 fix(eslint-plugin): ignore all whitespaces in comparison #4220 Nov 26, 2021
@armano2 armano2 added bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin labels Nov 26, 2021
@nx-cloud
Copy link

nx-cloud bot commented Nov 26, 2021

@armano2 armano2 changed the title fix(eslint-plugin): ignore all whitespaces in comparison #4220 fix(eslint-plugin): ignore all whitespaces in comparison Nov 26, 2021
@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #4223 (c594102) into main (4aaa34e) will increase coverage by 0.61%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4223      +/-   ##
==========================================
+ Coverage   92.73%   93.35%   +0.61%     
==========================================
  Files         335      152     -183     
  Lines       11541     8055    -3486     
  Branches     3288     2589     -699     
==========================================
- Hits        10703     7520    -3183     
+ Misses        364      179     -185     
+ Partials      474      356     -118     
Flag Coverage Δ
unittest 93.35% <100.00%> (+0.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/ban-types.ts 100.00% <100.00%> (ø)
...ckages/scope-manager/src/lib/webworker.iterable.ts
...pt-estree/src/ts-estree/estree-to-ts-node-types.ts
packages/typescript-estree/src/simple-traverse.ts
packages/scope-manager/src/lib/es2015.symbol.ts
...ages/scope-manager/src/lib/es2018.asynciterable.ts
packages/scope-manager/src/lib/es5.ts
packages/scope-manager/src/lib/es2019.object.ts
packages/scope-manager/src/scope/TSEnumScope.ts
...e-manager/src/definition/TSEnumMemberDefinition.ts
... and 174 more

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[@typescript-eslint/ban-types] Does not detect {} with a line break inside
2 participants