Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-var-requires] do not report require created from createRequire #4221

Merged
merged 3 commits into from Nov 28, 2021

Conversation

asdf93074
Copy link
Contributor

@asdf93074 asdf93074 commented Nov 25, 2021

PR Checklist

Overview

Used this as a reference. Pretty much the same solution if I am not mistaken.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @asdf93074!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Nov 25, 2021

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: d7f2d78

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61a1033bde0cb20008bb8a47

😎 Browse the preview: https://deploy-preview-4221--typescript-eslint.netlify.app

@codecov
Copy link

codecov bot commented Nov 25, 2021

Codecov Report

Merging #4221 (d7f2d78) into main (4aaa34e) will increase coverage by 0.62%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4221      +/-   ##
==========================================
+ Coverage   92.73%   93.35%   +0.62%     
==========================================
  Files         335      152     -183     
  Lines       11541     8057    -3484     
  Branches     3288     2590     -698     
==========================================
- Hits        10703     7522    -3181     
+ Misses        364      179     -185     
+ Partials      474      356     -118     
Flag Coverage Δ
unittest 93.35% <100.00%> (+0.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/eslint-plugin/src/rules/no-var-requires.ts 90.00% <100.00%> (+2.50%) ⬆️
...rimental-utils/src/ts-eslint-scope/ScopeManager.ts
packages/scope-manager/src/lib/es2018.full.ts
packages/scope-manager/src/lib/es2015.iterable.ts
...-internal/src/rules/no-typescript-estree-import.ts
.../scope-manager/src/variable/ESLintScopeVariable.ts
...gin-internal/src/rules/no-poorly-typed-ts-props.ts
packages/scope-manager/src/scope/ForScope.ts
packages/scope-manager/src/scope/BlockScope.ts
...s/scope-manager/src/scope/ClassStaticBlockScope.ts
... and 174 more

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[no-var-requires] require created by createRequire should be ignored
3 participants