Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(experimental-utils): export RuleCreator interfaces #4199

Merged

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Also exports the types used by RuleCreator.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Nov 21, 2021

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: bd63054

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/619a7989a9365900084a83ca

😎 Browse the preview: https://deploy-preview-4199--typescript-eslint.netlify.app

@nx-cloud
Copy link

nx-cloud bot commented Nov 21, 2021

@codecov
Copy link

codecov bot commented Nov 21, 2021

Codecov Report

Merging #4199 (bd63054) into main (2e2ff5d) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4199      +/-   ##
==========================================
- Coverage   92.76%   92.70%   -0.06%     
==========================================
  Files         332      194     -138     
  Lines       11524     8678    -2846     
  Branches     3285     2691     -594     
==========================================
- Hits        10690     8045    -2645     
+ Misses        361      254     -107     
+ Partials      473      379      -94     
Flag Coverage Δ
unittest 92.70% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...experimental-utils/src/eslint-utils/RuleCreator.ts 80.00% <100.00%> (ø)
...ges/typescript-estree/src/create-program/shared.ts
...ges/scope-manager/src/lib/es2018.asyncgenerator.ts
packages/scope-manager/src/lib/es2015.generator.ts
packages/scope-manager/src/lib/es2015.ts
packages/scope-manager/src/lib/es2018.full.ts
...kages/scope-manager/src/lib/es2017.sharedmemory.ts
packages/scope-manager/src/lib/es2020.bigint.ts
packages/scope-manager/src/lib/es2019.array.ts
packages/scope-manager/src/lib/es2019.object.ts
... and 129 more

@bradzacher bradzacher added the bug Something isn't working label Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot generate declaration file when using ESLintUtils.RuleCreator
2 participants