Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-duplicate-imports] remove unnecessary type checking for node.source #4196

Merged

Conversation

sosukesuzuki
Copy link
Contributor

PR Checklist

Overview

Since v5.x, source of ExportNamedDeclaration, ExportAllDeclaration and ImportDeclaration is always StringLiteral.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @sosukesuzuki!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Nov 21, 2021

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: 4d303b8

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/6199fe894a73ee0008f64707

😎 Browse the preview: https://deploy-preview-4196--typescript-eslint.netlify.app

@sosukesuzuki sosukesuzuki changed the title fix(eslint-plugin): remove unnecessary type checking for node.source fix(eslint-plugin): [no-duplicate-imports] remove unnecessary type checking for node.source Nov 21, 2021
@codecov
Copy link

codecov bot commented Nov 21, 2021

Codecov Report

Merging #4196 (4d303b8) into main (2e2ff5d) will increase coverage by 0.60%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #4196      +/-   ##
==========================================
+ Coverage   92.76%   93.36%   +0.60%     
==========================================
  Files         332      152     -180     
  Lines       11524     8051    -3473     
  Branches     3285     2585     -700     
==========================================
- Hits        10690     7517    -3173     
+ Misses        361      179     -182     
+ Partials      473      355     -118     
Flag Coverage Δ
unittest 93.36% <50.00%> (+0.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/eslint-plugin/src/rules/no-duplicate-imports.ts 95.34% <50.00%> (-0.21%) ⬇️
packages/scope-manager/src/scope/FunctionScope.ts
packages/scope-manager/src/analyze.ts
packages/typescript-estree/src/ast-converter.ts
...s/scope-manager/src/lib/es2015.symbol.wellknown.ts
packages/scope-manager/src/lib/es7.ts
packages/scope-manager/src/scope/TypeScope.ts
...s/experimental-utils/src/eslint-utils/deepMerge.ts
...ges/experimental-utils/src/ts-eslint/RuleTester.ts
packages/scope-manager/src/lib/es2017.intl.ts
... and 171 more

@bradzacher bradzacher added the bug Something isn't working label Nov 23, 2021
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for cleaning this up!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants