Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

visitorKeys does not contain assertions property. #4177

Closed
3 tasks done
ota-meshi opened this issue Nov 18, 2021 · 1 comment · Fixed by #4178
Closed
3 tasks done

visitorKeys does not contain assertions property. #4177

ota-meshi opened this issue Nov 18, 2021 · 1 comment · Fixed by #4178
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working good first issue Good for newcomers package: visitor-keys Issues related to @typescript-eslint/visitor-keys

Comments

@ota-meshi
Copy link
Contributor

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have read the FAQ and my problem is not listed.

Repro

import foo from "mod" assert { type: "json" };

Expected Result

I expected that the implementation of the plugin rule could traverse the ImportAttribute node.

Actual Result

It is not actually traversed.

Additional Info

Versions

package version
@typescript-eslint/parser 5.4.0
TypeScript 4.5.0
ESLint 8.0.0
node 14
@ota-meshi ota-meshi added package: parser Issues related to @typescript-eslint/parser triage Waiting for maintainers to take a look labels Nov 18, 2021
@bradzacher
Copy link
Member

bradzacher commented Nov 18, 2021 •
edited

oops - this was missed in #4074.
the visitor keys for ImportAttribute were added but not for the parent nodes ExportAllDeclaration, ExportNamedDeclaration, ImportDeclaration and ImportExpression.

@bradzacher bradzacher added bug Something isn't working package: visitor-keys Issues related to @typescript-eslint/visitor-keys accepting prs Go ahead, send a pull request that resolves this issue good first issue Good for newcomers and removed triage Waiting for maintainers to take a look package: parser Issues related to @typescript-eslint/parser labels Nov 18, 2021
@ota-meshi ota-meshi mentioned this issue Nov 18, 2021
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working good first issue Good for newcomers package: visitor-keys Issues related to @typescript-eslint/visitor-keys
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(visitor-keys): add missing import assertion keys ota-meshi/typescript-eslint
2 participants
@bradzacher @ota-meshi