Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint-plugin): [prefer-for-of] do nor error when iterating over this #4176

Merged
merged 3 commits into from Nov 23, 2021
Merged

fix(eslint-plugin): [prefer-for-of] do nor error when iterating over this #4176

merged 3 commits into from Nov 23, 2021

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Nov 17, 2021 •
edited

PR Checklist

@armano2 armano2 added bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin labels Nov 17, 2021
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Nov 17, 2021 •
edited

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: a5720e2

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/619595c73959060007d02b0e

😎 Browse the preview: https://deploy-preview-4176--typescript-eslint.netlify.app

@armano2 armano2 self-assigned this Nov 17, 2021
@nx-cloud
Copy link

nx-cloud bot commented Nov 17, 2021 •
edited

Nx Cloud Report

CI ran the following commands for commit a5720e2. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-internal
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx run-many --target=typecheck --all --parallel
#000000 Node 14.x - nx test @typescript-eslint/parser
#000000 Node 14.x - nx test @typescript-eslint/experimental-utils
#000000 Node 14.x - nx test @typescript-eslint/scope-manager
#000000 Node 14.x - nx test @typescript-eslint/visitor-keys
#000000 Node 14.x - nx test @typescript-eslint/typescript-estree
#000000 Node 14.x - nx run-many --target=build --all --parallel --exclude website --exclude website
#000000 Node 12.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx test @typescript-eslint/experimental-utils
#000000 Node 12.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx test @typescript-eslint/experimental-utils

Sent with 💌 from NxCloud.

@armano2 armano2 marked this pull request as draft November 17, 2021 23:39
@armano2 armano2 changed the title fix(eslint-plugin): [prefer-for-of] do not error when used on this expression fix(eslint-plugin): [prefer-for-of] do nor error when iterating over this Nov 17, 2021
@armano2 armano2 marked this pull request as ready for review November 17, 2021 23:52
bradzacher
bradzacher approved these changes Nov 23, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bradzacher bradzacher merged commit 258ddb0 into main Nov 23, 2021
@bradzacher bradzacher deleted the fix/prefer-for-of branch November 23, 2021 23:49
This was referenced Nov 30, 2021
Open
Open
Open
Open
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees

@armano2 armano2

Labels
bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[prefer-for-of] Ignore Symbol.iterator and Symbol.asyncIterator methods
2 participants
@armano2 @bradzacher